When shutting down the OTel providers have a ten second timeout.#3199
Conversation
I noticed a misconfigured metrics URL would prevent the process from quiting because it was trying to flush metrics forever.
|
/assign @evankanderson @Cali0707 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3199 +/- ##
==========================================
- Coverage 75.99% 75.96% -0.03%
==========================================
Files 205 205
Lines 11709 11709
==========================================
- Hits 8898 8895 -3
- Misses 2541 2543 +2
- Partials 270 271 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/lgtm I would even argue for a shorter shutdown (2-5s, and/or use a configurable timeout), but 10s seems plenty. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, evankanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I noticed a misconfigured metrics URL would prevent the process
from quiting because it was trying to flush metrics forever.