export MinimumVersion() accessor#3350
Conversation
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
knative-prow
Bot
added
the
size/S
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3350 +/- ##
=======================================
Coverage 74.87% 74.88%
=======================================
Files 189 189
Lines 8347 8349 +2
=======================================
+ Hits 6250 6252 +2
Misses 1853 1853
Partials 244 244 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
approved
|
|
||
| // MinimumVersion returns the minimum Kubernetes version Knative is built | ||
| // and tested against. The returned value has a leading "v" (e.g. "v1.34.0"). | ||
| func MinimumVersion() string { |
There was a problem hiding this comment.
This is a bit confusing since we also have getMinimumVersion below.
Maybe we should just expose defaultMinimumVersion as DefaultKubernetesMinVersion const
and expose getMinimumVersion as KubernetesMinimumVersion()
3 participants
Changes
Expose the minimum Kubernetes version Knative is built and tested against via a new exported function, so tools that need the target version before a cluster exists can read it directly instead of hardcoding and hand-bumping it each release.
xref knative-extensions/kn-plugin-quickstart#644