Skip to content

[release-1.21] Fix compilation#3361

Merged
knative-prow[bot] merged 1 commit into
knative:release-1.21from
dprotaso:release-121-fix-compilation
May 29, 2026
Merged

[release-1.21] Fix compilation#3361
knative-prow[bot] merged 1 commit into
knative:release-1.21from
dprotaso:release-121-fix-compilation

Conversation

@dprotaso
Copy link
Copy Markdown
Member

@dprotaso dprotaso commented May 28, 2026

newer go versions found this bug and made it a compiler error

@knative-prow knative-prow Bot added area/test-and-release size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 28, 2026
@knative-prow knative-prow Bot requested review from evankanderson and mgencur May 28, 2026 21:27
@dprotaso
Copy link
Copy Markdown
Member Author

/assign @dsimansk @linkvt

@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.87%. Comparing base (18c5d58) to head (dbabe51).
⚠️ Report is 2 commits behind head on release-1.21.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.21    #3361      +/-   ##
================================================
- Coverage         74.90%   74.87%   -0.03%     
================================================
  Files               189      189              
  Lines              8275     8275              
================================================
- Hits               6198     6196       -2     
- Misses             1839     1840       +1     
- Partials            238      239       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot merged commit 9b08ba8 into knative:release-1.21 May 29, 2026
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants