Skip to content

fix: replace deprecated git.io goreleaser link in vendored gen-crd-api-reference-docs#16571

Closed
Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Ankitsinghsisodya:pr/replace-deprecated-gitio-goreleaser
Closed

fix: replace deprecated git.io goreleaser link in vendored gen-crd-api-reference-docs#16571
Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Ankitsinghsisodya:pr/replace-deprecated-gitio-goreleaser

Conversation

@Ankitsinghsisodya
Copy link
Copy Markdown
Contributor

Proposed change

Replace https://git.io/goreleaser with the canonical goreleaser install script in vendor/github.com/ahmetb/gen-crd-api-reference-docs/.travis.yml. The git.io shortener is deprecated and was retired; using a direct URL avoids relying on redirects.

Fixes #16570

Context

  • Same pattern as updating other git.io links to stable destinations.
  • This file is part of a vendored dependency; the change keeps the example Travis deploy script on a reliable URL.

Release note

N/A (vendor metadata; upstream CI example only).

…n method

Replace deprecated https://git.io/goreleaser with the canonical goreleaser install script URL in vendored gen-crd-api-reference-docs.

Fixes knative#16570
Copilot AI review requested due to automatic review settings April 23, 2026 00:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knative-prow knative-prow Bot requested review from dsimansk and skonto April 23, 2026 00:08
@knative-prow knative-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 23, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 23, 2026

Hi @Ankitsinghsisodya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 23, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ankitsinghsisodya
Once this PR has been reviewed and has the lgtm label, please assign skonto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.33%. Comparing base (24d9522) to head (0f4c49b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16571      +/-   ##
==========================================
+ Coverage   80.30%   80.33%   +0.03%     
==========================================
  Files         217      217              
  Lines       17305    17305              
==========================================
+ Hits        13896    13902       +6     
+ Misses       3046     3038       -8     
- Partials      363      365       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@linkvt
Copy link
Copy Markdown
Contributor

linkvt commented Apr 23, 2026

Hi @Ankitsinghsisodya ,
thanks for the PR but this is not how vendor directories work, see https://victoriametrics.com/blog/vendoring-go-mod-vendor/
You can try fixing the issue in the repository of the dependency.

AI tools are not 100% reliable so please make sure you understand the changes/issues identified.

/close

@knative-prow knative-prow Bot closed this Apr 23, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 23, 2026

@linkvt: Closed this PR.

Details

In response to this:

Hi @Ankitsinghsisodya ,
thanks for the PR but this is not how vendor directories work, see https://victoriametrics.com/blog/vendoring-go-mod-vendor/
You can try fixing the issue in the repository of the dependency.

AI tools are not 100% reliable so please make sure you understand the changes/issues identified.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace deprecated git.io goreleaser link in vendored gen-crd-api-reference-docs

3 participants