Allow custom ports for the primary container's livenessProbe#16572
Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom Apr 25, 2026
Merged
Allow custom ports for the primary container's livenessProbe#16572knative-prow[bot] merged 1 commit intoknative:mainfrom
knative-prow[bot] merged 1 commit intoknative:mainfrom
Conversation
…enabled When the multi-container-probing feature flag is enabled, the reconciler now preserves user-specified custom ports on the primary container's HTTP and TCP liveness probes instead of overwriting them to the serving containerPort. This supports applications (e.g. Spring Boot Actuator) that expose health endpoints on a separate management port. When the flag is disabled (default), existing strict behavior is preserved. Signed-off-by: Mikhail Fedosin <mfedosin@redhat.com>
knative-prow
Bot
added
the
size/L
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16572 +/- ##
==========================================
- Coverage 80.36% 80.32% -0.05%
==========================================
Files 217 217
Lines 17305 17310 +5
==========================================
- Hits 13907 13904 -3
- Misses 3035 3043 +8
Partials 363 363 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/test istio-latest-no-mesh |
1 similar comment
Contributor
Author
|
/test istio-latest-no-mesh |
Contributor
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, Fedosin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
multi-container-probingfeature flag is enabled, the reconciler now preserves user-specified custom ports on the primary container's HTTP and TCP liveness probes instead of unconditionally overwriting them to the servingcontainerPort.8081), which previously entered a crash loop because the probe was forced to hit the serving port where no health endpoint existed.Release Note