Skip to content

Remove k8s resource in e2e test #6530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 1 commit into from
Feb 26, 2020
Merged

Remove k8s resource in e2e test #6530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/e2e/autoscale_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ func setup(t *testing.T, class, metric string, target, targetUtilization float64
}),
}, fopts...)...)
if err != nil {
test.TearDown(clients, names)
t.Fatalf("Failed to create initial Service: %v: %v", names.Service, err)
}

Expand Down
6 changes: 3 additions & 3 deletions test/e2e/destroypod_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,17 +61,17 @@ func TestDestroyPodInflight(t *testing.T) {
Route: svcName,
Image: "timeout",
}
test.CleanupOnInterrupt(func() { test.TearDown(clients, names) })
defer test.TearDown(clients, names)

t.Log("Creating a new Route and Configuration")
if _, err := v1a1test.CreateConfiguration(t, clients, names, v1a1opts.WithConfigRevisionTimeoutSeconds(revisionTimeoutSeconds)); err != nil {
t.Fatalf("Failed to create Configuration: %v", err)
}
if _, err := v1a1test.CreateRoute(t, clients, names); err != nil {
t.Fatalf("Failed to create Route: %v", err)
}

test.CleanupOnInterrupt(func() { test.TearDown(clients, names) })
defer test.TearDown(clients, names)

t.Log("When the Revision can have traffic routed to it, the Route is marked as Ready")
if err := v1a1test.WaitForRouteState(clients.ServingAlphaClient, names.Route, v1a1test.IsRouteReady, "RouteIsReady"); err != nil {
t.Fatalf("The Route %s was not marked as Ready to serve traffic: %v", names.Route, err)
Expand Down