Implement krshaped for networking#7879
Conversation
knative-prow-robot
left a comment
There was a problem hiding this comment.
@whaught: 0 warnings.
Details
In response to this:
Issue #1226
Proposed Changes
- Implements the KRShaped interface for the v1alpha1 networking resources
- Will allow common logic in the generated reconciler
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Co-authored-by: Matt Moore <mattmoor@vmware.com>
|
The following jobs failed:
Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests: |
|
The following is the coverage report on the affected files.
|
|
/assign @nak3 |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: whaught, ZhiminXiang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@whaught: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Issue #1226
Proposed Changes