Skip to content

Statserver test cleanup and benchmark enhancement.#8622

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
markusthoemmes:cleanup-statserver
Jul 14, 2020
Merged

Statserver test cleanup and benchmark enhancement.#8622
knative-prow-robot merged 1 commit intoknative:masterfrom
markusthoemmes:cleanup-statserver

Conversation

@markusthoemmes
Copy link
Contributor

Proposed Changes

  • A few touchups to test functions and helpers.
  • Adds back different amounts of messages to be sent per iteration to more closely resemble what the activator is actually doing and to surface potential for optimization in future iterations.

Release Note

NONE

/assign @julz

- A few touchups to test functions and helpers.
- Adds back different amounts of messages to be sent per iteration to more closely resemble what the activator is actually doing and to surface potential for optimization in future iterations.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 14, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 14, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2020
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markusthoemmes: 0 warnings.

Details

In response to this:

Proposed Changes

  • A few touchups to test functions and helpers.
  • Adds back different amounts of messages to be sent per iteration to more closely resemble what the activator is actually doing and to surface potential for optimization in future iterations.

Release Note

NONE

/assign @julz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/autoscaler/statserver/server.go 81.2% 83.8% 2.5

Copy link
Contributor

@julz julz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2020
@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-integration-tests pull-knative-serving-integration-tests 1/3

Automatically retrying due to test flakiness...
/test pull-knative-serving-integration-tests

@knative-prow-robot knative-prow-robot merged commit 138a165 into knative:master Jul 14, 2020
@julz julz mentioned this pull request Jul 23, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants