Skip to content

Require that spec.subscriber is set for Subscription. #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 3 commits into from
Sep 2, 2021
Merged

Require that spec.subscriber is set for Subscription. #30

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6cda57e
Require that spec.subscriber is set for Subscription.
evankanderson Jul 25, 2021
576cc25
Merge branch 'main' of https://github.com/knative/specs into unreplied
Sep 2, 2021
41e1c01
Clarify MUST on discard, thanks Doug
Sep 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions specs/eventing/control-plane.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,11 +230,9 @@ condition MUST indicate the reason for the error. The Subscription MUST also set
`status.physicalSubscription` URIs to the empty string if the corresponding
`spec` reference cannot be resolved.

At least one of `spec.subscriber` and `spec.reply` MUST be set; if only
`spec.reply` is set, the behavior is equivalent to setting `spec.subscriber`
except that the Channel SHOULD NOT
[advertise the ability to process replies](data-plane.md#derived-reply-events)
during the delivery.
The `spec.subscriber` destination MUST be set; if the `spec.reply` field is not
set, [replies](data-plane.md#derived-reply-events) from the `spec.subscriber`
MUST be discarded.

Once created, the Subscription's `spec.channel` MUST NOT permit updates; to
change the `spec.channel`, the Subscription MUST be deleted and re-created. This
Expand Down Expand Up @@ -651,7 +649,7 @@ resource. The `apiVersion` is `messaging.knative.dev/v1` and the `kind` is
</tr>
<tr>
<td><code>subscriber</code></td>
<td><a href="#duckv1destination">duckv1.Destination</a><br/>(OPTIONAL)</td>
<td><a href="#duckv1destination">duckv1.Destination</a><br/>(REQUIRED)</td>
<td>The destination for event delivery.</td>
</tr>
<tr>
Expand Down