Handle edge cases with PAT token ENV import

[xZero707]

One of the issues I've encountered is that I had a newline in my PAT token. This was causing the script to fail with the following:

node:_http_outgoing:702
validateHeaderValue(name, value);
^

TypeError [ERR_INVALID_CHAR]: Invalid character in header content ["Authorization"]
at ClientRequest.setHeader (node:_http_outgoing:702:3)
at new ClientRequest (node:_http_client:302:14)
at Object.request (node:https:381:10)
at RedirectableRequest._performRequest (/usr/src/app/node_modules/follow-redirects/index.js:265:24)
at new RedirectableRequest (/usr/src/app/node_modules/follow-redirects/index.js:61:8)
at Object.request (/usr/src/app/node_modules/follow-redirects/index.js:456:14)
at dispatchHttpRequest (/usr/src/app/node_modules/axios/lib/adapters/http.js:195:25)
at new Promise (<anonymous>)
at httpAdapter (/usr/src/app/node_modules/axios/lib/adapters/http.js:46:10)
at dispatchRequest (/usr/src/app/node_modules/axios/lib/core/dispatchRequest.js:52:10) {
code: 'ERR_INVALID_CHAR'
}

After figuring out the cause, I come up with simple and effective patch for such cases.

Additionally, I implemented some extra error handling to handle the case where the environment can be only PAT_. This would cause the script to attempt to use the empty key on the map, as PAT_ is stripped of it.

[n0vad3v]

Thanks for feedback, may I ask in which case there will be a newline in PAT token?

[xZero707]

In this particular case I modified image a bit and added s6 overlay and docker-env-secrets. Before kms service is started, secrets are loaded into the environment.
Eg. /run/secrets/PAT_myorg will be available as PAT_myorg environment variable and so on. Loading of the files is handled by s6 with-contenv wrapper and s6-envdir.

My compose.yaml (partial):

secrets:
  PAT_myorg:
    file: ./secrets/PAT_myorg.txt

networks:
  default:

services:
  kms:
    image: xcr.se/n0rthernl1ghts/gha-runner-kms:latest # My custom build
    hostname: example.router0.net
    deploy:
      restart_policy:
        condition: any
    secrets:
      - PAT_myorg
    networks:
      default:
      
(...)

Secret file secrets/PAT_myorg.txt is created with text editor. Like nano - Some editors will always add newline.

Code should be able to handle such cases. Trim is an easy choice.

[n0vad3v]

Got it, nice work!
I'll port this to my Rust port (https://github.com/knatnetwork/github-runner-kms-rs) later, as github-runner-kms-rs has a smaller image and starts faster than this Node version of KMS.