Skip to content

Conversation

@knealking
Copy link
Owner

This PR includes several improvements and fixes:

Changes

  • Workflow Updates: Updated workflow triggers to include release events
  • Test Infrastructure: Added notes for failed tests and example tests
  • Build System: Removed failing test program and added check/distcheck targets
  • CI/CD: Added GitHub Actions workflow for makefile
  • Documentation: Updated CONTRIBUTING.md with correct test commands
  • File Organization: Reorganized files and updated ignore patterns
  • Test Framework: Added comprehensive test suite with binary search examples
  • Core Features: Implemented Rust-style test framework with assertion utilities

Key Features Added

  • Binary search implementation (iterative and recursive)
  • Comprehensive test examples
  • Build automation with Makefile
  • Consistent coding standards with .editorconfig
  • Contributor guidelines

This represents a significant enhancement to the assertc project with improved testing, documentation, and build processes.

@knealking knealking self-assigned this Jun 1, 2025
@knealking knealking requested a review from Copilot June 1, 2025 06:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the CI/CD workflow, testing infrastructure, build process, and documentation for the assertc project.

  • Updated README.md with additional test examples and an important note regarding test exclusions
  • Revised the Makefile by removing the failing test target, adding error handling to the test runner, and introducing new targets (check and distcheck)
  • Added a GitHub Actions workflow to integrate makefile-based builds and tests

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
README.md Added guidance on test examples and noted exclusion of a failing test file
Makefile Removed failing test, improved test error handling, and added new targets (check, distcheck)
.github/workflows/makefile.yml Introduced a new workflow for CI with targets for check and distcheck

@knealking knealking merged commit 0eca483 into main Jun 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants