Small changes#140
Merged
Merged
Conversation
- Rename (and reverse) `allow_false` to `require_truth` (because `allow_false = false` is a really counter-intuitive way to require truth) - Rename `ch_weights` to `course_weights`
Previously, `MethodLib::get_by_title_with_suggestions` would return a reference to method titles within the `MethodLib`. This avoids cloning a few `String`s but makes for a nastier API if the error is expected to outlive the `MethodLib` it came from (which happens in Monument). Cloning a few small `String`s is never going to be a bottleneck - and we're not even in the happy path anymore because we're handling errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.