Fix duplicate recurring enqueues when multiple schedulers run#54
Merged
Fix duplicate recurring enqueues when multiple schedulers run#54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_or_createRecurringExecution.AlreadyRecordedto skip duplicate runsrun_atdouble enqueueUnreleasedWhy
When two scheduler instances enqueue the same recurring task at the same
run_at,update_or_createallowed both jobs to be enqueued and the second worker only updated the record. This caused duplicate job execution.This aligns behavior with Solid Queue's
AlreadyRecordedflow.Closes #52
Validation
uv run python manage.py test tests.test_recurring_execution --keepdbuv run python manage.py test tests.test_recurring_task tests.test_recurring_execution --keepdbuv run ruff check steady_queue/models/recurring_execution.py steady_queue/models/recurring_task.py tests/test_recurring_execution.py