Use atomic writes for versions.lock in resolve script#31
Merged
Conversation
Write the lockfile to a temp file first, then atomically move it into place on success. A cleanup trap removes the temp file if the script exits early due to a resolver failure, preventing a truncated or partially written lockfile from replacing the existing one. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents a truncated or partially written
versions.lockif the resolve script exits mid-run. The lockfile is now written to a temp file first and atomically moved into place on success, with a cleanup trap that removes the temp file on early exit.Related Issues
Fixes #23
Changes
versions.lockmvthe temp file into place after a successful writeEXITtrap to clean up the temp file on script failure