Declare curl and jq as deb package runtime dependencies#43
Merged
Conversation
validate-action-pins requires curl and jq at runtime. Without a depends declaration, apt won't pull them in automatically. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
These are now declared as deb dependencies in nfpm.yaml, so apt pulls them in automatically when installing the package. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lex57ukr
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate-action-pinsrequirescurlandjqat runtime but the deb package didn't declare them as dependencies. Without adependsdeclaration innfpm.yaml,apt-get install ci-toolswon't pull them in automatically. The script degrades gracefully (warns and exits 0) but won't do anything useful without them.Related Issues
Refs #38
Changes
depends: [curl, jq]tonfpm.yamlso apt resolves them automaticallycurl jqinstall fromverify-deb-install.shsince they now come in as declared dependenciesFurther Comments
Verified locally with
make test-package— both debian:bookworm-slim and ubuntu:24.04 pass all checks with the dependencies pulled in via apt automatically.