Skip to content

Conversation

@knightedcodemonkey
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings January 16, 2026 19:08
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 86.53846% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.56%. Comparing base (0726c2a) to head (418c907).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/css/src/stableSelectorsLiteral.ts 68.75% 5 Missing ⚠️
packages/css/src/helpers.ts 94.28% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   91.57%   91.56%   -0.01%     
==========================================
  Files          13       13              
  Lines        3668     3700      +32     
  Branches      644      647       +3     
==========================================
+ Hits         3359     3388      +29     
- Misses        281      284       +3     
  Partials       28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates linting tooling and improves TypeScript strictness by replacing any types with proper type annotations. It upgrades oxlint from v1.35.0 to v1.39.0, adds stricter linting rules to enforce no any types, and refactors code to comply with these new rules. It also adds an AGENTS.md file documenting the project for AI coding assistants.

Changes:

  • Upgraded oxlint to v1.39.0 and enabled stricter TypeScript linting rules
  • Replaced any types with proper TypeScript type definitions across source and test files
  • Added AGENTS.md documentation file for AI coding agents

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Updated oxlint dependency from ^1.35.0 to ^1.39.0
package-lock.json Updated oxlint and platform-specific package versions and checksums
.oxlintrc.json Added eslint plugin and stricter TypeScript rules (@typescript-eslint/no-explicit-any)
AGENTS.md Added new documentation file for AI coding assistants with project guidelines
packages/css/src/helpers.ts Replaced any types with proper Lightning CSS type definitions
packages/css/src/stableSelectorsLiteral.ts Replaced any types with proper Lightning CSS type definitions
packages/css/src/moduleGraph.ts Changed any to unknown in type assertion
packages/css/test/css.test.ts Updated test code to use proper types instead of any

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey knightedcodemonkey merged commit 99eaebc into main Jan 16, 2026
6 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch January 16, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants