Skip to content

Conversation

@knightedcodemonkey
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings January 18, 2026 03:44
@codecov
Copy link

codecov bot commented Jan 18, 2026

Codecov Report

❌ Patch coverage is 92.05607% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.22%. Comparing base (af0d9d2) to head (b3bca3c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/css/src/moduleResolution.ts 92.21% 12 Missing and 1 partial ⚠️
packages/css/src/generateTypes.ts 88.88% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   92.17%   92.22%   +0.05%     
==========================================
  Files          13       14       +1     
  Lines        3860     3924      +64     
  Branches      681      690       +9     
==========================================
+ Hits         3558     3619      +61     
- Misses        275      278       +3     
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves module resolution for the CLI tool by refactoring resolution logic into a dedicated module and adding support for package.json imports field (hash imports) resolution.

Changes:

  • Extracted module resolution utilities into a new moduleResolution.ts file for better code organization
  • Fixed handling of hash imports (package.json imports field) by correctly parsing specifiers that start with #
  • Added comprehensive test coverage for package.json imports and hash-imports workspace scenarios

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/css/src/moduleResolution.ts New file containing extracted module resolution utilities (normalizeResolverResult, resolveWithFactory, createResolverFactory, etc.)
packages/css/src/moduleGraph.ts Refactored to use the new moduleResolution module, removing duplicated code
packages/css/src/generateTypes.ts Integrated resolver factory for better module resolution, added realpath normalization for rootDir, fixed hash import parsing in splitResourceAndQuery
packages/css/test/generateTypes.test.ts Added comprehensive tests for package.json imports and hash-imports workspace scenarios, updated fixture setup to use realpath
packages/css/package.json Version bump from 1.1.0-rc.2 to 1.1.0-rc.3
packages/playwright/package.json Updated @knighted/css dependency to 1.1.0-rc.3
package-lock.json Updated lockfile to reflect version changes
packages/playwright/src/hash-imports-workspace/apps/hash-import-demo/tsconfig.json Expanded rootDir and include paths to support workspace-wide module resolution
packages/playwright/src/hash-imports-workspace/apps/hash-import-demo/src/workspace-bridge/hash-imports.css New CSS file with knighted-demo class for testing
packages/playwright/src/hash-imports-workspace/apps/hash-import-demo/src/render-hash-imports-demo.ts Added import and usage of hash-imports.css stable selectors

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey knightedcodemonkey merged commit 2423c9e into main Jan 18, 2026
12 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch January 18, 2026 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants