Skip to content

Conversation

@knightedcodemonkey
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings January 19, 2026 18:23
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 87.17391% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.66%. Comparing base (7b3b45c) to head (bec04f2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/css/src/loaderBridge.ts 87.17% 58 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   93.27%   92.66%   -0.62%     
==========================================
  Files          14       15       +1     
  Lines        4105     4565     +460     
  Branches      738      817      +79     
==========================================
+ Hits         3829     4230     +401     
- Misses        249      307      +58     
- Partials       27       28       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a loader bridge feature that enables CSS module hashed class names to be used with the existing knighted-css loader ecosystem. The bridge allows developers to leverage their existing CSS Modules pipeline while still accessing compiled CSS strings via the knightedCss export for use cases like Shadow DOM styling.

Changes:

  • Adds new @knighted/css/loader-bridge loader that wraps existing CSS Modules output without reprocessing
  • Migrates webpack configuration from ts-loader to swc-loader for TypeScript transpilation
  • Includes comprehensive test coverage with both unit tests and end-to-end Playwright tests across rspack and webpack

Reviewed changes

Copilot reviewed 19 out of 22 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
packages/css/src/loaderBridge.ts Core implementation of the bridge loader with CSS text and modules resolution
packages/css/test/loaderBridge.test.ts Unit tests for bridge loader internals
packages/playwright/test/bridge-loader.spec.ts E2E tests verifying bridge loader works in both rspack and webpack
packages/playwright/webpack.bridge.config.js Webpack configuration for bridge demo
packages/playwright/rspack.bridge.config.js Rspack configuration for bridge demo
packages/playwright/src/bridge/* Demo implementation showing bridge loader usage with Lit and React
packages/playwright/webpack.config.js Migration from ts-loader to swc-loader
packages/css/package.json Version bump to 1.1.0-rc.6 and loader-bridge export
packages/css/loader-queries.d.ts Type definitions for knightedCssModules export
docs/loader.md Documentation for the new bridge loader feature
packages/playwright/package.json Updated dependencies and build scripts
.gitignore Added bridge build output directories

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey
Copy link
Owner Author

@copilot review commit 8533ab7

Copy link

Copilot AI commented Jan 19, 2026

@knightedcodemonkey I've opened a new pull request, #65, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI review requested due to automatic review settings January 19, 2026 19:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 22 changed files in this pull request and generated 8 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 19, 2026 21:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 22 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey knightedcodemonkey merged commit 32d5edc into main Jan 19, 2026
6 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch January 19, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants