-
Notifications
You must be signed in to change notification settings - Fork 0
feat: loader bridge for css module hashed class names. #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
- Coverage 93.27% 92.66% -0.62%
==========================================
Files 14 15 +1
Lines 4105 4565 +460
Branches 738 817 +79
==========================================
+ Hits 3829 4230 +401
- Misses 249 307 +58
- Partials 27 28 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces a loader bridge feature that enables CSS module hashed class names to be used with the existing knighted-css loader ecosystem. The bridge allows developers to leverage their existing CSS Modules pipeline while still accessing compiled CSS strings via the knightedCss export for use cases like Shadow DOM styling.
Changes:
- Adds new
@knighted/css/loader-bridgeloader that wraps existing CSS Modules output without reprocessing - Migrates webpack configuration from
ts-loadertoswc-loaderfor TypeScript transpilation - Includes comprehensive test coverage with both unit tests and end-to-end Playwright tests across rspack and webpack
Reviewed changes
Copilot reviewed 19 out of 22 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/css/src/loaderBridge.ts | Core implementation of the bridge loader with CSS text and modules resolution |
| packages/css/test/loaderBridge.test.ts | Unit tests for bridge loader internals |
| packages/playwright/test/bridge-loader.spec.ts | E2E tests verifying bridge loader works in both rspack and webpack |
| packages/playwright/webpack.bridge.config.js | Webpack configuration for bridge demo |
| packages/playwright/rspack.bridge.config.js | Rspack configuration for bridge demo |
| packages/playwright/src/bridge/* | Demo implementation showing bridge loader usage with Lit and React |
| packages/playwright/webpack.config.js | Migration from ts-loader to swc-loader |
| packages/css/package.json | Version bump to 1.1.0-rc.6 and loader-bridge export |
| packages/css/loader-queries.d.ts | Type definitions for knightedCssModules export |
| docs/loader.md | Documentation for the new bridge loader feature |
| packages/playwright/package.json | Updated dependencies and build scripts |
| .gitignore | Added bridge build output directories |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@knightedcodemonkey I've opened a new pull request, #65, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 19 out of 22 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 19 out of 22 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.