Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Integrates CodeMirror 6 as a rich code editor for the JSX and CSS panels, loaded asynchronously from CDN with graceful textarea fallback.
Changes:
- Added CodeMirror editor factory (
editor-codemirror.js) with full theme, syntax highlighting, and language compartment support - Wired CodeMirror initialization into
app.jswith source abstraction (getJsxSource/getCssSource) and style-mode language reconfiguration - Added CDN import specs for all required CodeMirror packages, plus documentation and agent instructions
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/editor-codemirror.js | New CodeMirror editor factory with CDN runtime loading, theme, and language support |
| src/app.js | Editor initialization, source abstraction, style-mode language switching |
| src/cdn.js | CDN import specs for 8 CodeMirror packages |
| src/styles.css | Editor host styling, panel height constraints, responsive rules |
| docs/code-mirror.md | Documentation for integration rules, fallback behavior, troubleshooting |
| docs/build-and-deploy.md | Cross-reference to new CodeMirror docs |
| AGENTS.md | Agent instructions for the repository |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.