Skip to content

fix: consistent head handling.#96

Merged
knightedcodemonkey merged 4 commits intonextfrom
bananas
Apr 24, 2026
Merged

fix: consistent head handling.#96
knightedcodemonkey merged 4 commits intonextfrom
bananas

Conversation

@knightedcodemonkey
Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings April 24, 2026 15:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to make PR drawer “head” (and related PR drawer metadata) behave consistently across repository/context transitions by ensuring programmatic form updates trigger workspace-metadata persistence, and by ensuring a fresh local workspace has a non-empty head branch that can be persisted/restored.

Changes:

  • Added helpers to set PR drawer form values while emitting input events so workspace metadata persistence runs for programmatic updates.
  • Ensured inactive/local workspaces start with a generated head branch and that startup flushes an initial workspace save early.
  • Added Playwright coverage for bootstrapping persistence and head stability across repository changes.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/modules/github/pr/drawer/controller/repository-form.js Emits metadata input events when setting repo/base/head/title programmatically to persist workspace metadata.
src/modules/github/pr/drawer/controller/create-controller.js Forces a full form sync after hydrating an active PR context.
src/modules/app-core/workspace-pr-session-handoff-controller.js Generates a fresh local head branch and persists it into the created inactive workspace record.
src/modules/app-core/app-bindings-startup.js Persists PR repo select changes and flushes an initial workspace save after bootstrap completes.
src/app.js Wires githubPrRepoSelect into startup bindings.
playwright/github-pr-drawer.spec.ts Adds tests for early persistence, head persistence, and head stability across repo changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/modules/app-core/workspace-pr-session-handoff-controller.js Outdated
@knightedcodemonkey knightedcodemonkey merged commit 5c916c9 into next Apr 24, 2026
10 of 11 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch April 24, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants