Skip to content

fix: babel default interop issue. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knightedcodemonkey merged 1 commit into from
Apr 2, 2025
Merged

fix: babel default interop issue. #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
134 changes: 74 additions & 60 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@knighted/module",
"version": "1.0.0-alpha.5",
"version": "1.0.0-alpha.6",
"description": "Converts module differences in source files between ES and CommonJS.",
"type": "module",
"main": "dist/module.js",
Expand Down Expand Up @@ -75,8 +75,9 @@
"dependencies": {
"@babel/parser": "^7.27.0",
"@babel/traverse": "^7.27.0",
"@knighted/specifier": "^2.0.0-rc.4",
"magic-string": "^0.30.10"
"@knighted/specifier": "^2.0.1",
"magic-string": "^0.30.10",
"node-module-type": "^1.0.2"
},
"prettier": {
"arrowParens": "avoid",
Expand Down
11 changes: 10 additions & 1 deletion src/format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import MagicString from 'magic-string'
import _traverse from '@babel/traverse'
import { moduleType } from 'node-module-type'

import type { ParseResult } from '@babel/parser'
import type { File } from '@babel/types'
Expand All @@ -9,7 +10,15 @@ import { identifier } from './formatters/identifier.js'
import { metaProperty } from './formatters/metaProperty.js'
import { memberExpression } from './formatters/memberExpression.js'

const traverse = _traverse.default
/**
* Runtime hack to prevent issues with babel's default interop while dual building with tsc.
* @see https://github.com/babel/babel/discussions/13093#discussioncomment-12705927
* Temporary fix until I switch to oxc-parser.
*/
const type = moduleType()
const traverse = (
typeof _traverse === 'function' || type === 'commonjs' ? _traverse : _traverse.default
) as typeof _traverse.default

/**
* Note, there is no specific conversion for `import.meta.main` as it does not exist.
Expand Down