Todo/eslint config vue ignore camel case aria label#280
Merged
Conversation
hejtful
requested review from
Copilot and
knime-ghub-bot
and removed request for
a team
🦋 Changeset detectedLatest commit: 085092c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ChristianAlbrecht
approved these changes
Mar 26, 2026
hriverahdez
approved these changes
Mar 26, 2026
There was a problem hiding this comment.
Pull request overview
Updates the @knime/eslint-config Vue 3 ESLint preset to stop flagging the ariaLabel prop for Vue components, reducing the need for per-template eslint-disable vue/attribute-hyphenation workarounds across the monorepo.
Changes:
- Configure
vue/attribute-hyphenationto ignore theariaLabelattribute name in Vue SFC templates. - Add a patch changeset for
@knime/eslint-configdocumenting the lint behavior change.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/lint/vue3.js | Adds vue/attribute-hyphenation configuration to ignore ariaLabel while keeping hyphenation enforced for other attributes. |
| .changeset/upset-cycles-marry.md | Declares a patch release for @knime/eslint-config to publish the updated Vue lint rule behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.