Add parameter validation and fix model switch test

[bashandbone]

Description

Add validation to find_code API to enforce reasonable parameter bounds and improve test coverage.

Test File TODOs

1. Validate max_results Bounds (test_find_code_contract.py:380)

Add validation in find_code to enforce:

• Minimum: 1
• Maximum: 100000

Current State:

• No validation on max_results
• Tests note this should be enforced

2. Validate max_chunks_per_file Bounds (test_find_code_contract.py:389)

Add validation in find_code to enforce:

• Minimum: 1
• Maximum: 100

Current State:

• No validation on max_chunks_per_file
• Tests note this should be enforced

3. Fix Model Switch Test (test_model_switch.py:86)

Test isn't testing the correct behavior for model switching warnings.

Current Problem:
Comment states: "This isn't testing the correct thing. The warning should raise if the embedding provider changes but the model doesn't"

Expected Behavior:

• Warning when provider changes but model stays the same
• This indicates potential embedding incompatibility
• Current test doesn't capture this scenario

Implementation

API Validation

Add to find_code():

if max_results < 1 or max_results > 100000:
    raise ValueError("max_results must be between 1 and 100000")
    
if max_chunks_per_file < 1 or max_chunks_per_file > 100:
    raise ValueError("max_chunks_per_file must be between 1 and 100")

Test Fix

Rewrite model switch test to:

1. Change provider while keeping model name
2. Expect warning about incompatibility
3. Verify warning message content

Benefits

• Safety: Prevent unreasonable parameter values
• Correctness: Tests validate actual requirements
• User experience: Clear error messages

Source

• Files: test_find_code_contract.py:380,389, test_model_switch.py:86
• Branch: 003-our-aim-to

[github-actions]

Claude finished @bashandbone's task —— View job

---

Analysis Complete - Need Clarification

Tasks

• Read repository setup and constitutional guidelines
• Locate find_code function implementation
• Search for test files mentioned in the issue
• Add validation for max_results parameter (1-100000)
• Add validation for max_chunks_per_file parameter (1-100)
• Fix model switch test to verify correct warning behavior
• Run tests to verify changes
• Commit and push changes

Findings

I've reviewed the codebase and found:

1. find_code implementation: Located at src/codeweaver/agent_api/find_code.py:49-68

   • Currently a stub implementation during refactoring
   • Has max_results parameter but no max_chunks_per_file parameter
   • No validation present

2. Test files not found: The files mentioned in the issue don't exist in the current branch:

   • test_find_code_contract.py - not found
   • test_model_switch.py - not found

3. Branch reference: The issue mentions branch 003-our-aim-to, but this branch doesn't exist in the repository (only main and origin/main are visible)

Questions

@bashandbone - Could you clarify:

1. Are these test files that need to be created as part of this issue, or do they exist on a different branch?
2. Should I add the max_chunks_per_file parameter to the find_code function signature (it's currently not present)?
3. The current find_code is a stub - should I add validation to this stub, or wait until the full implementation is restored?
4. For the model switch test, what's the expected scenario? Should I create a new test file or modify an existing integration test?

Current find_code signature

async def find_code(
    query: str,
    *,
    intent: str | None = None,
    token_limit: int = 10000,
    include_tests: bool = False,
    focus_languages: tuple[str, ...] | None = None,
    max_results: int = 50,  # ← Found this parameter
    # max_chunks_per_file: ??? ← Not present
) -> dict:

---