Skip to content

🧹 Remove deprecated and unused combined_lifespan alias#226

Merged
bashandbone merged 1 commit intomainfrom
chore/remove-deprecated-combined-lifespan-11695823115261314285
Mar 16, 2026
Merged

🧹 Remove deprecated and unused combined_lifespan alias#226
bashandbone merged 1 commit intomainfrom
chore/remove-deprecated-combined-lifespan-11695823115261314285

Conversation

@bashandbone
Copy link
Contributor

@bashandbone bashandbone commented Mar 16, 2026

🎯 What: Removed the deprecated combined_lifespan backward compatibility alias and its comment in src/codeweaver/server/lifespan.py.
💡 Why: This assignment (combined_lifespan = http_lifespan) is no longer used. Removing it eliminates dead code, improves code health, and reduces potential confusion regarding the module's API.
Verification: Verified by checking references in the codebase (it was completely unused) and running uv run pytest tests/unit/server/ --no-cov. All 32 server-related tests passed, ensuring no functionality is broken.
Result: A cleaner lifespan.py without deprecated aliases, leading to better maintainability and readability.


PR created automatically by Jules for task 11695823115261314285 started by @bashandbone

Summary by Sourcery

Enhancements:

  • Clean up the server lifespan module by removing an obsolete backward compatibility alias.

The `combined_lifespan` assignment and associated comment in `src/codeweaver/server/lifespan.py` were unused dead code that provided a deprecated alias. Removing this improves code health and maintainability by keeping the module surface smaller and less confusing. All tests pass with no regressions.

Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings March 16, 2026 03:26
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 16, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes the deprecated and unused combined_lifespan alias to simplify the lifespan server module’s public API and eliminate dead code.

File-Level Changes

Change Details Files
Remove deprecated combined_lifespan alias that pointed to http_lifespan, tightening the module’s public surface and eliminating dead code.
  • Deleted the comment describing the backward compatibility alias as deprecated
  • Removed the combined_lifespan = http_lifespan assignment
  • Left the all export list unchanged so only background_services_lifespan and http_lifespan remain public
src/codeweaver/server/lifespan.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a deprecated backward-compatibility alias (combined_lifespan) from the server lifespan module to eliminate dead code and reduce API confusion.

Changes:

  • Deleted the deprecated combined_lifespan = http_lifespan alias.
  • Removed the associated deprecation comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bashandbone bashandbone merged commit 8628669 into main Mar 16, 2026
15 of 20 checks passed
@bashandbone bashandbone deleted the chore/remove-deprecated-combined-lifespan-11695823115261314285 branch March 16, 2026 03:39
Copilot AI pushed a commit that referenced this pull request Mar 17, 2026
The `combined_lifespan` assignment and associated comment in `src/codeweaver/server/lifespan.py` were unused dead code that provided a deprecated alias. Removing this improves code health and maintainability by keeping the module surface smaller and less confusing. All tests pass with no regressions.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants