Skip to content

test: update CircuitBreakerState to use .variable#228

Merged
bashandbone merged 1 commit intomainfrom
fix-baseenum-variable-6088664127128084659
Mar 16, 2026
Merged

test: update CircuitBreakerState to use .variable#228
bashandbone merged 1 commit intomainfrom
fix-baseenum-variable-6088664127128084659

Conversation

@bashandbone
Copy link
Contributor

@bashandbone bashandbone commented Mar 16, 2026

Fixes # FIX: comments in tests/integration/server/test_health_monitoring.py by replacing .value or plain string literals assigned to circuit_breaker_state.variable with the proper CircuitBreakerState.<STATE>.variable enum properties.

Also updates tests/integration/server/test_error_recovery.py to use .variable instead of .value for consistency with the BaseEnum interface.


PR created automatically by Jules for task 6088664127128084659 started by @bashandbone

Summary by Sourcery

Align circuit breaker state handling in tests with the CircuitBreakerState enum’s variable-based interface.

Bug Fixes:

  • Correct circuit breaker state assignments in health monitoring tests to use the enum’s variable property instead of raw strings.

Enhancements:

  • Update error recovery and health monitoring tests to use CircuitBreakerState..variable for consistency with the BaseEnum interface.

Tests:

  • Adjust integration tests for error recovery and health monitoring to reference CircuitBreakerState variables rather than enum values or string literals.

Updates test_error_recovery.py and test_health_monitoring.py to align
with the BaseEnum interface by using `.variable` on CircuitBreakerState
enum entries instead of `.value` or string literals. Also removed
the `# FIX:` comments regarding this change.

Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings March 16, 2026 03:49
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 16, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Standardizes tests to use CircuitBreakerState..variable instead of .value or string literals when setting circuit_breaker_state, aligning with the BaseEnum interface and removing FIX comments in health monitoring tests.

File-Level Changes

Change Details Files
Update circuit breaker state usage in error recovery tests to reference the enum .variable property instead of .value.
  • Replace CircuitBreakerState.CLOSED.value assignments with CircuitBreakerState.CLOSED.variable for mock providers’ circuit_breaker_state.
  • Replace CircuitBreakerState.OPEN.value assignments with CircuitBreakerState.OPEN.variable when simulating circuit opening.
  • Replace CircuitBreakerState.HALF_OPEN.value assignments with CircuitBreakerState.HALF_OPEN.variable when simulating half-open transitions.
tests/integration/server/test_error_recovery.py
Replace hard-coded circuit breaker state strings in health monitoring tests with CircuitBreakerState..variable.
  • Set mock embedding and reranking providers’ circuit_breaker_state.variable to CircuitBreakerState.CLOSED.variable instead of the string 'closed'.
  • Set circuit_breaker_state.variable to CircuitBreakerState.OPEN.variable in degraded health tests instead of 'open'.
  • Set circuit_breaker_state.variable to CircuitBreakerState.HALF_OPEN.variable and CircuitBreakerState.OPEN.variable in circuit breaker exposure tests instead of 'half_open' and 'open' string literals, cleaning up previous FIX comments.
tests/integration/server/test_health_monitoring.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@bashandbone bashandbone merged commit a0a09b9 into main Mar 16, 2026
12 of 17 checks passed
@bashandbone bashandbone deleted the fix-baseenum-variable-6088664127128084659 branch March 16, 2026 03:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates integration tests to use CircuitBreakerState.<STATE>.variable consistently (instead of .value or hard-coded strings) when setting circuit breaker state in provider mocks.

Changes:

  • Replace string literals assigned to circuit_breaker_state.variable with CircuitBreakerState.<STATE>.variable in health monitoring tests.
  • Replace .value usages with .variable in error recovery tests to align with the BaseEnum interface.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tests/integration/server/test_health_monitoring.py Imports CircuitBreakerState and uses its .variable when configuring mocked provider circuit breaker state.
tests/integration/server/test_error_recovery.py Switches mock provider circuit_breaker_state assignments from .value to .variable for consistency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

embedding_instance.circuit_breaker_state.variable = CircuitBreakerState.HALF_OPEN.variable

response2 = await health_service.get_health_response()
assert response2.services.embedding_provider.circuit_breaker_state == "half_open"
embedding_instance.circuit_breaker_state.variable = CircuitBreakerState.OPEN.variable

response3 = await health_service.get_health_response()
assert response3.services.embedding_provider.circuit_breaker_state == "open"
Copilot AI pushed a commit that referenced this pull request Mar 17, 2026
Updates test_error_recovery.py and test_health_monitoring.py to align
with the BaseEnum interface by using `.variable` on CircuitBreakerState
enum entries instead of `.value` or string literals. Also removed
the `# FIX:` comments regarding this change.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants