Skip to content

🧹 Fix unused import: IsRetryable#76

Merged
bashandbone merged 2 commits into
mainfrom
fix-unused-import-isretryable-11622467603668314133
Mar 13, 2026
Merged

🧹 Fix unused import: IsRetryable#76
bashandbone merged 2 commits into
mainfrom
fix-unused-import-isretryable-11622467603668314133

Conversation

@bashandbone
Copy link
Copy Markdown
Contributor

🎯 What: The code health issue addressed is an unused import of the IsRetryable trait in crates/recoco-utils/src/http.rs.
💡 Why: By removing the IsRetryable import and directly calling the trait method retryable::IsRetryable::is_retryable(&err) using fully qualified syntax, we resolve the linter warning about the unused import without breaking compilation. This improves code health and maintainability by removing unnecessary imports and clarifying where the trait method comes from.
Verification: I ran cargo check -p recoco-utils --all-features to ensure no new errors or warnings are introduced due to the missing import and confirmed the compilation succeeds. I also ran ./dev/run_cargo_test.sh to ensure no functionality is broken.
Result: The codebase is cleaner and doesn't trigger unused import warnings for the IsRetryable trait in http.rs.


PR created automatically by Jules for task 11622467603668314133 started by @bashandbone

Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings March 13, 2026 02:51
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Mar 13, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
recoco-docs 42b473e Commit Preview URL

Branch Preview URL
Mar 13 2026, 03:04 AM

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an unused trait import in http.rs by switching to a fully-qualified trait-method call, eliminating the linter warning without changing behavior.

Changes:

  • Dropped the IsRetryable trait import.
  • Invoked is_retryable via retryable::IsRetryable::is_retryable(&err) instead of method syntax.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread crates/recoco-utils/src/http.rs Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Adam Poulemanos <89049923+bashandbone@users.noreply.github.com>
@bashandbone bashandbone merged commit f0df8a4 into main Mar 13, 2026
6 of 8 checks passed
@bashandbone bashandbone deleted the fix-unused-import-isretryable-11622467603668314133 branch March 13, 2026 03:04
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Recoco v1.0.0 Mar 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🤖 Hi @bashandbone, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hey @bashandbone,

Thanks for your contribution to codeweaver! 🧵

You need to agree to the CLA first... 🖊️

Before we can accept your contribution, you need to agree to our Contributor License Agreement (CLA).

To agree to the CLA, please comment:

I read the contributors license agreement and I agree to it.

Those exact words are important1, so please don't change them. 😉

You can read the full CLA here: Contributor License Agreement


@bashandbone has signed the CLA.


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Footnotes

  1. Our bot needs those exact words to recognize that you agree to the CLA.

@github-actions
Copy link
Copy Markdown
Contributor

🤖 I'm sorry @bashandbone, but I was unable to process your request. Please see the logs for more details.

@github-actions github-actions Bot locked and limited conversation to collaborators Mar 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants