fix: tracking table setup must occur after all target setups#93
Merged
bashandbone merged 3 commits intomainfrom Mar 13, 2026
Merged
fix: tracking table setup must occur after all target setups#93bashandbone merged 3 commits intomainfrom
bashandbone merged 3 commits intomainfrom
Conversation
…ream bug fix) Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
recoco-docs | 8e1afb3 | Mar 13 2026, 09:32 PM |
Copilot
AI
changed the title
[WIP] [Upstream-Sync] Fix execution plan initialization order
fix: tracking table setup must occur after all target setups
Mar 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR mirrors an upstream fix to ensure flow setup applies target setup changes before tracking table setup, preventing the execution plan from observing partially-initialized target state.
Changes:
- Reorders
apply_changes_for_flowso target resource setup runs first. - Moves tracking table setup to run after all target kinds have been processed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Adam Poulemanos <89049923+bashandbone@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors upstream fix cocoindex-io/cocoindex#1715. In
apply_changes_for_flow, the tracking table was being set up before targets were fully initialized, allowing the execution plan to observe incomplete target state.Change
crates/recoco-core/src/setup/driver.rs— reorder setup operations inapply_changes_for_flow:The commit/metadata logic and everything else in
apply_changes_for_flowis unchanged — this is purely an ordering fix.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.