add a copy button to body area #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a copy button to the request body area, along with localization entries and positioning adjustments.
- Introduced new i18n keys for “copy” and “copied” in both English and Chinese.
- Wrapped the body display in a relatively positioned container and added a copy button with icon and localized label.
- Updated CSS classes to position the button at the top-right of the body block.
Comments suppressed due to low confidence (1)
templates/main.tmpl:218
- New copy-button functionality is introduced here but lacks accompanying tests. Consider adding a UI or integration test to verify that clicking the button copies the correct text and updates the button label to “copied.”
<div class="relative">
| <pre class="bg-gray-800 text-white p-4 rounded-md text-sm overflow-x-auto"><code>{{prettyPrintJson .SelectedRequest.Body}}</code></pre> | ||
| <div class="relative"> | ||
| <pre id="body-text" class="bg-gray-800 text-white p-4 rounded-md text-sm overflow-x-auto"><code>{{prettyPrintJson .SelectedRequest.Body}}</code></pre> | ||
| <button id="copy-body-btn" class="absolute top-2 right-2 bg-blue-600 hover:bg-blue-700 text-white p-2 rounded-md text-xs transition-colors duration-200 flex items-center gap-1" title="复制正文内容"> |
There was a problem hiding this comment.
The button's title attribute is hard-coded in Chinese, even for the English locale. Consider using a data-i18n attribute or a dedicated locale key for the title to ensure proper translation.
| <div class="relative"> | ||
| <pre id="body-text" class="bg-gray-800 text-white p-4 rounded-md text-sm overflow-x-auto"><code>{{prettyPrintJson .SelectedRequest.Body}}</code></pre> | ||
| <button id="copy-body-btn" class="absolute top-2 right-2 bg-blue-600 hover:bg-blue-700 text-white p-2 rounded-md text-xs transition-colors duration-200 flex items-center gap-1" title="复制正文内容"> | ||
| <svg class="w-4 h-4" fill="none" viewBox="0 0 24 24" stroke="currentColor"> |
There was a problem hiding this comment.
The SVG is decorative and should include aria-hidden="true" (or role="img" with a proper title) so screen readers don’t announce it unnecessarily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.