Skip to content

Conversation

@kylemcd
Copy link
Member

@kylemcd kylemcd commented Nov 6, 2025

Description

Upgrades next and react to the latest versions, this included a few other updates to get things working. There are no functional changes to the code. All code related updates are strictly type changes. In addition to this, the linting has changed with next so this swaps out our the previous linting config with a comparable on that works with the latest version of next.

@linear
Copy link

linear bot commented Nov 6, 2025

@vercel
Copy link

vercel bot commented Nov 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Ready Ready Preview Comment Nov 6, 2025 9:04pm

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Icon Mismatch Breaks BuildingBlock Rendering Runtime Error

The BuildingBlock component always renders the icon using <Icon icon={_icon as LucideIcon} .../>, but doesn't check if _icon is an IconComponent function first. Unlike the Tool and ContentCard components which use typeof _icon === "function" to conditionally render IconComponent functions by calling them directly, BuildingBlock will incorrectly pass IconComponent functions to the Icon component, which expects a LucideIcon type. This will cause runtime errors when IconComponent icons (like those from the Icons object) are used with BuildingBlock.

components/ui/OverviewContent/Blocks.tsx#L211-L226

</MenuItem>
);
};
export const BuildingBlock = ({
title,
description,
icon,
href = "#",
}: {
title: string;
description: string;
icon: IconType;
href: string;
}) => {
const _icon = getIcon(icon);

Fix in Cursor Fix in Web


Copy link
Contributor

@MikeCarbone MikeCarbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested many pages through the preview link. Each major page type appears to be functioning as expected. Code is fine, glad types are cleaned up. Thanks for doing that!

@kylemcd kylemcd merged commit 573fe44 into main Nov 6, 2025
5 checks passed
@kylemcd kylemcd deleted the kyle-kno-10290-nextjs-version-no-longer-receiving-security-updates branch November 6, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants