chore: Update yarn to yarn-4.9.1#1399
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
37125a1 to
79673a3
Compare
79673a3 to
95f0c0f
Compare
5b85f0d to
1bd0361
Compare
| .pnp.js | ||
| .pnp.* | ||
| .yarn/ | ||
| .yarnrc.yml |
There was a problem hiding this comment.
I must note the yarn updation migration created one of these files
.yarnrc.yml, with nodeLinker set to nodeModules, which I believe was undesired behavior.
So I reverted that change and added to git ignore.
Its undesired bc we use pnp?
kylemcd
left a comment
There was a problem hiding this comment.
can reference this PR for how to do this
Will fix |
1bd0361 to
dad74d8
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9574432. Configure here.
|
|
||
| - name: Install dependencies | ||
| run: yarn install | ||
| run: yarn install --immutable |
There was a problem hiding this comment.
CI dependency caching removed without replacement
Low Severity
The old workflow cached yarn dependencies via actions/cache@v4, but this was removed during the Yarn 4 migration without adding any replacement caching mechanism. Every CI run now does a full yarn install from scratch. The actions/setup-node@v4 action supports built-in dependency caching via the cache input (e.g., cache: 'yarn'), but it's not being used here. Note that corepack enable would likely need to run before setup-node for Yarn Berry cache detection to work correctly.
Reviewed by Cursor Bugbot for commit 9574432. Configure here.
9574432 to
cf69517
Compare
This file is auto-generated by Next.js and the path change was introduced accidentally during the yarn install step. Made-with: Cursor
cf69517 to
acbbe59
Compare
There was a problem hiding this comment.
Risk HIGH: Upgrades the project from Yarn 1 to Yarn 4.9.1, bundling the new binary, regenerating the lockfile, updating CI workflow, and modifying package.json with new resolutions and engine constraints.
Reasons
package.jsonis modified with newresolutions,engines,packageManagerfield, and inlined pre-scripts (HIGH trigger: rule 2)yarn.lockis fully regenerated in Yarn 4 format with ~16k lines changed (HIGH trigger: rule 2).github/workflows/cicd.ymlbuild/deployment configuration is modified — removes yarn caching, adds corepack, switches to--immutable(HIGH trigger: rule 3)- New
.yarnrc.ymlconfig file introducesnodeLinkerandyarnPathsettings that change how dependency resolution works bin/bootstrap.shremoves theasdf plugin add yarnstep, changing the developer setup flow
Notes
- Verify the Vercel preview deployment builds and runs correctly with the new Yarn 4 setup (preview appears to be deployed successfully per the Vercel bot comment)
- Confirm that
corepack enableworks reliably in CI and thatyarn install --immutableenforces the lockfile as expected - Review the
package.jsonscript changes:predev/prebuildhooks were removed and their logic inlined intodev/build— ensure Yarn 4 does not also runprehooks (which could cause double execution) - Check that the
@types/reactand@types/react-domresolution pins to19.2.2don't conflict with the actual React version used - The new
globdependency (^10.3.10) was added — confirm this is intentionally part of this PR and not an unrelated change
Sent by Cursor Automation: Docs PR classifier





Yarn upgrade:
4.9.1).docs/.yarn/releases/yarn-4.9.1.cjsand activates it viayarnPathindocs/.yarnrc.yml— matches the approach used in the Telegraph and JS SDK repos, and works correctly regardless of what's installed globally.New files: