chore(react): remove clsx dependency (KNO-13814)#1020
Closed
kylemcd wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 17, 2026
🦋 Changeset detectedLatest commit: d8d7d22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1020 +/- ##
==========================================
- Coverage 63.55% 63.44% -0.12%
==========================================
Files 208 208
Lines 9924 10000 +76
Branches 1280 1280
==========================================
+ Hits 6307 6344 +37
- Misses 3592 3631 +39
Partials 25 25
|
Member
Author
|
Combined into #1024. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Removes the
clsxruntime dependency from@knocklabs/react. Every call site was the simple "merge a static class with the incomingclassNameprop" pattern (e.g.clsx("knock-guide-banner", className)), so all ~29 sites across the guide components now composeclassNamenatively:No
cx/clsxhelper is vendored — zero added utility code, one fewer runtime dependency.What changed
Banner.tsx,Card.tsx,Modal.tsxin the guide module — replaced everyclsx(...)call with native composition.clsxfrompackages/react/package.jsonand updated the lockfile.clsxstill appears in the lockfile, but only as a transitive dependency of the@telegraph/*packages — it is no longer a direct dependency of ours.Why: Part of the npm supply chain hardening effort — fewer third-party runtime dependencies in our (and our consumers') install graphs.
Linear: KNO-13814
Stack (bottom → top) — npm supply chain hardening:
clsxfrom@knocklabs/react◀ this PRjwt-decodein@knocklabs/clientlodash.debouncein@knocklabs/reactfast-deep-equalin@knocklabs/react-coreChecklist
yarn test).