feat: split providers into KnockFeedProvider and KnockProvider#2
Merged
connorlindsey merged 4 commits intomainfrom Dec 13, 2023
Merged
Conversation
KNO-4820 Update React providers
Create separate Knock and KnockFeed providers Reorganize code around |
meryldakin
approved these changes
Dec 12, 2023
cjbell
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits the feed provider into a
KnockProviderandKnockFeedProvider. TheKnockProviderauthenticates with Knock and exposes a client. TheKnockFeedProvidernow must be a child of theKnockProviderand is only responsible for connecting to the feed and getting notifications.