fix: utilize telegraph lucide-react instance so versions are synced #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 24f780b The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kylemcd
requested review from
cjbell,
connorlindsey,
emisilvacab,
mattmikolay and
thomaswhyyou
and removed request for
a team,
emisilvacab and
thomaswhyyou
connorlindsey
approved these changes
Oct 7, 2025
kylemcd
deleted the
kyle-kno-9992-sync-lucide-react-versions-between-telegraph-and-javascript
branch
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #778 +/- ##
=======================================
Coverage 64.29% 64.29%
=======================================
Files 185 185
Lines 7710 7710
Branches 934 934
=======================================
Hits 4957 4957
Misses 2727 2727
Partials 26 26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The versions for
lucide-reactbecame out of sync since they're included in both telegraph and this repo. To fix this, I've removed thelucide-reactpackage.jsonreferences so that when importing icons fromlucide-reactwe are utilizing the version from telegraph.We also update telegraph to latest versions in this PR since we just upgraded
lucide-reactin telegraph.