-
Notifications
You must be signed in to change notification settings - Fork 12
Revert "feat: add LocationSensor helper component for next AppRouter and PagesRouter" #793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "feat: add LocationSensor helper component for next AppRouter and PagesRouter" #793
Conversation
…and Page…" This reverts commit 4b888c4.
🦋 Changeset detectedLatest commit: 42930be The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #793 +/- ##
==========================================
+ Coverage 65.84% 66.06% +0.21%
==========================================
Files 188 185 -3
Lines 7753 7706 -47
Branches 950 950
==========================================
- Hits 5105 5091 -14
+ Misses 2624 2591 -33
Partials 24 24
|
Reverts #789
Note
Removes Next.js-specific LocationSensor components and Next peer/dev deps, and consolidates guide client event listener cleanup.
LocationSensorNextAppRouterandLocationSensorNextPagesRouterand their exports frompackages/react/src/index.ts,modules/guide/components, andmodules/guide/index.ts.nextfrompeerDependenciesand dev deps inpackages/react/package.json(and lockfile updates).removeLocationChangeEventListenerstoremoveEventListenersand use it incleanup(); remove a redundant log inhandleLocationChange.@knocklabs/clientand@knocklabs/react.Written by Cursor Bugbot for commit 42930be. This will update automatically on new commits. Configure here.