Skip to content

Conversation

@thomaswhyyou
Copy link
Contributor

@thomaswhyyou thomaswhyyou commented Oct 29, 2025

Reverts #789


Note

Removes Next.js-specific LocationSensor components and Next peer/dev deps, and consolidates guide client event listener cleanup.

  • React (guide components):
    • Remove Next.js helper components LocationSensorNextAppRouter and LocationSensorNextPagesRouter and their exports from packages/react/src/index.ts, modules/guide/components, and modules/guide/index.ts.
  • React package config:
    • Drop next from peerDependencies and dev deps in packages/react/package.json (and lockfile updates).
  • Client (guide):
    • Rename removeLocationChangeEventListeners to removeEventListeners and use it in cleanup(); remove a redundant log in handleLocationChange.
  • Changeset:
    • Patch releases for @knocklabs/client and @knocklabs/react.

Written by Cursor Bugbot for commit 42930be. This will update automatically on new commits. Configure here.

@thomaswhyyou thomaswhyyou requested a review from a team as a code owner October 29, 2025 17:21
@thomaswhyyou thomaswhyyou requested review from kylemcd and mattmikolay and removed request for a team October 29, 2025 17:21
@linear
Copy link

linear bot commented Oct 29, 2025

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2025

🦋 Changeset detected

Latest commit: 42930be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@knocklabs/client Patch
@knocklabs/react Patch
client-example Patch
guide-example Patch
@knocklabs/expo Patch
@knocklabs/react-core Patch
@knocklabs/react-native Patch
ms-teams-connect-example Patch
nextjs-app-dir-example Patch
nextjs-example Patch
slack-connect-example Patch
slack-kit-example Patch
@knocklabs/expo-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview Comment Oct 29, 2025 5:30pm
javascript-nextjs-example Ready Ready Preview Comment Oct 29, 2025 5:30pm
javascript-slack-connect-example Ready Ready Preview Comment Oct 29, 2025 5:30pm
javascript-slack-kit-example Ready Ready Preview Comment Oct 29, 2025 5:30pm

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.06%. Comparing base (5b6cb86) to head (42930be).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
+ Coverage   65.84%   66.06%   +0.21%     
==========================================
  Files         188      185       -3     
  Lines        7753     7706      -47     
  Branches      950      950              
==========================================
- Hits         5105     5091      -14     
+ Misses       2624     2591      -33     
  Partials       24       24              
Files with missing lines Coverage Δ
packages/client/src/clients/guide/client.ts 87.21% <100.00%> (-0.02%) ⬇️
packages/react/src/index.ts 100.00% <ø> (ø)
...ckages/react/src/modules/guide/components/index.ts 100.00% <ø> (ø)
packages/react/src/modules/guide/index.ts 100.00% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants