chore(PLA-2206): add exponential backoff with jitter to Phoenix socket reconnection#862
Merged
Conversation
🦋 Changeset detectedLatest commit: 40b89e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
daaab17 to
8cc5e5a
Compare
2994091 to
9f91d7c
Compare
9f91d7c to
3adb5b2
Compare
3adb5b2 to
90e91dc
Compare
90e91dc to
40b89e3
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #862 +/- ##
==========================================
+ Coverage 66.96% 67.28% +0.32%
==========================================
Files 203 203
Lines 8539 8537 -2
Branches 1104 1109 +5
==========================================
+ Hits 5718 5744 +26
+ Misses 2801 2768 -33
- Partials 20 25 +5
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The default Phoenix Socket reconnection schedule is deterministic and aggressive (first retry at 10ms, no randomization), which causes all clients to slam the server at the same instant when connectivity is restored. This configures
reconnectAfterMsandrejoinAfterMson the Phoenix Socket with exponential backoff and full jitter to try to mitigate some thundering herd problems during outages or deployments.