Skip to content

chore: refactor to use run config state as an object for guide toolbar v2#885

Merged
thomaswhyyou merged 2 commits intomainfrom
thomas-kno-11800-toolbar-read-and-write-debug-toolbar-params-via-local
Mar 3, 2026
Merged

chore: refactor to use run config state as an object for guide toolbar v2#885
thomaswhyyou merged 2 commits intomainfrom
thomas-kno-11800-toolbar-read-and-write-debug-toolbar-params-via-local

Conversation

@thomaswhyyou
Copy link
Copy Markdown
Contributor

@thomaswhyyou thomaswhyyou commented Mar 3, 2026

Description

A small refactor to make the guide toolbar's internal state an object and fold isVisible in there. This state object will capture any query params from the url to configure the toolbar (hence "run config"). The motivation for moving this to an object instead of the current isVisible boolean, is so that we can start supporting more than one query params like focusedGuideKey later.

@linear
Copy link
Copy Markdown

linear Bot commented Mar 3, 2026

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview, Comment Mar 3, 2026 4:15pm
javascript-nextjs-example Ready Ready Preview, Comment Mar 3, 2026 4:15pm
javascript-slack-connect-example Ready Ready Preview, Comment Mar 3, 2026 4:15pm
javascript-slack-kit-example Ready Ready Preview, Comment Mar 3, 2026 4:15pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 3, 2026

⚠️ No Changeset found

Latest commit: 96520dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor Author

thomaswhyyou commented Mar 3, 2026

@thomaswhyyou
Copy link
Copy Markdown
Contributor Author

@cursor review

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment thread packages/react/src/modules/guide/components/Toolbar/V2/V2.tsx
@thomaswhyyou thomaswhyyou merged commit 56f7d58 into main Mar 3, 2026
10 of 12 checks passed
@thomaswhyyou thomaswhyyou deleted the thomas-kno-11800-toolbar-read-and-write-debug-toolbar-params-via-local branch March 3, 2026 20:10
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 12.50000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.76%. Comparing base (1fc0b37) to head (651484b).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 9.09% 10 Missing ⚠️
...src/modules/guide/components/Toolbar/V2/helpers.ts 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #885      +/-   ##
==========================================
- Coverage   66.79%   66.76%   -0.03%     
==========================================
  Files         207      207              
  Lines        9182     9186       +4     
  Branches     1224     1224              
==========================================
  Hits         6133     6133              
- Misses       3025     3029       +4     
  Partials       24       24              
Files with missing lines Coverage Δ
...src/modules/guide/components/Toolbar/V2/helpers.ts 25.00% <20.00%> (-2.28%) ⬇️
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 14.40% <9.09%> (-0.36%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants