chore: refactor to use run config state as an object for guide toolbar v2#885
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
a8db9c1 to
96520dd
Compare
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #885 +/- ##
==========================================
- Coverage 66.79% 66.76% -0.03%
==========================================
Files 207 207
Lines 9182 9186 +4
Branches 1224 1224
==========================================
Hits 6133 6133
- Misses 3025 3029 +4
Partials 24 24
|

Description
A small refactor to make the guide toolbar's internal state an object and fold
isVisiblein there. This state object will capture any query params from the url to configure the toolbar (hence "run config"). The motivation for moving this to an object instead of the currentisVisibleboolean, is so that we can start supporting more than one query params like focusedGuideKey later.