Skip to content

feat: add open in dashboard in guide toolbar v2 #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thomaswhyyou wants to merge 3 commits into
base: thomas-kno-12204-toolbar-beta-qa-and-feedback-items-10
Choose a base branch
from
+24 −3
Draft

feat: add open in dashboard in guide toolbar v2 #932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04a04a9
add open in dashboard and reset engagement buttons
thomaswhyyou Apr 2, 2026
8a1bc4d
style updates
thomaswhyyou Apr 2, 2026
2077e86
changeset
thomaswhyyou Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/happy-grapes-relate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@knocklabs/client": patch
"@knocklabs/react": patch
---

[Guides] Add a Open in dashboard button to guide toolbar v2
1 change: 1 addition & 0 deletions packages/client/src/clients/guide/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ export interface GuideData<TContent = Any> {
activation_url_rules: GuideActivationUrlRuleData[];
activation_url_patterns: GuideActivationUrlPatternData[];
bypass_global_group_limit: boolean;
dashboard_url: string;
inserted_at: string;
updated_at: string;
}
Expand Down
20 changes: 17 additions & 3 deletions packages/react/src/modules/guide/components/Toolbar/V2/GuideRowDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { Button } from "@telegraph/button";
import { Box, Stack } from "@telegraph/layout";
import { Tooltip } from "@telegraph/tooltip";
import { Text } from "@telegraph/typography";
Expand Down Expand Up @@ -30,7 +31,7 @@ const CardContainer = ({
bg="surface-1"
border="px"
borderColor="gray-4"
style={{ flex: 1 }}
style={{ flex: 1, alignSelf: "stretch" }}
>
<Text as="span" size="0" color="gray" weight="medium">
{title}
Expand Down Expand Up @@ -135,7 +136,7 @@ export const GuideRowDetails = ({
);

return (
<Stack px="3" py="2" gap="2" direction="row" align="flex-start">
<Stack p="1" gap="2" direction="row" align="flex-start">
<CardContainer title="Eligibility">
<StatusRow
label="Active"
Expand All @@ -156,7 +157,6 @@ export const GuideRowDetails = ({
tooltip="Whether the current user matches the guide's targeting conditions."
/>
</CardContainer>

<CardContainer title="Visibility">
<StatusRow
label="Activation"
Expand Down Expand Up @@ -185,6 +185,20 @@ export const GuideRowDetails = ({
</Tooltip>
</StatusRow>
</CardContainer>
<Stack
direction="column"
justify="flex-end"
gap="1"
style={{ alignSelf: "stretch" }}
>
<Button
size="0"
variant="outline"
onClick={() => window.open(guide.dashboard_url, "_blank", "noopener")}
>
Open in dashboard
</Button>
</Stack>
</Stack>
);
};
Loading