chore: cache the last settled annotated guides in guide toolbar#965
Merged
thomaswhyyou merged 3 commits intomainfrom Apr 17, 2026
Conversation
Cache the last settled orderedGuides in useInspectGuideClientStore and serve it while the guide client's group stage is transiently cleared or re-opening. Without this, every row's status dots collapsed to undefined (rendering as gray/"Not queried") during the ~50ms order resolution window after Focus toggles, navigation, or other stage-clearing events. The stage is treated as settled on "closed" and "patch" statuses (both preserve stage.results), and transient on undefined or "open".
🦋 Changeset detectedLatest commit: 8d5fb38 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Author
|
@cursor review |
thomaswhyyou
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 878abf4. Configure here.
thomaswhyyou
requested review from
a team,
connorlindsey and
meryldakin
and removed request for
a team
connorlindsey
approved these changes
Apr 17, 2026
thomaswhyyou
deleted the
thomas-kno-12730-flashing-issue-when-switching-guides-with-focus-button
branch
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #965 +/- ##
==========================================
+ Coverage 64.00% 64.04% +0.04%
==========================================
Files 209 209
Lines 10074 10086 +12
Branches 1299 1304 +5
==========================================
+ Hits 6448 6460 +12
Misses 3601 3601
Partials 25 25
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This aims to address the "flickers" seen with the query status dots when navigating or moving focus, by caching the annotated guides and only re-annotating (and re-rendering in toolbar bar) when the guide client's group state resolution settles. This allows the toolbar to skip re-rendering during a transient/interim state in the guide client.