Refactor v1 #5
Merged
Refactor v1 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Starting on initial refactor * initial refactor * Implemented shared Knock instance * added device unregistration functionality * Added more safety around the userId checks * Cleanup * Make KnockError a LocalizedError * Updated KnockOptions init * updates
* Starting on initial refactor * initial refactor * Implemented shared Knock instance * added device unregistration functionality * Added more safety around the userId checks * Cleanup * Make KnockError a LocalizedError * Updated KnockOptions init * updates * Introduce Modules and Services for independent responsibilities * Authentication * fixes * set version on api base path * Fixes * fix * implementation fix * Updated logging * Working on tests * created shared Knock instance * refactored logging * refactored logging * Adding more tests --------- Co-authored-by: Matt Gardner <mattgardner@Knock-MBP.local>
* Documentation updates and refactor KnockEnvironment to be and actor to avoid race conditions * adding token handling * readme updates --------- Co-authored-by: Matt Gardner <mattgardner@Knock-MBP.local>
# Conflicts: # Knock.podspec # README.md # Sources/KnockAPI.swift # Sources/Models/Feed/FeedItem.swift
cjbell
approved these changes
Mar 13, 2024
Contributor
cjbell
left a comment
cjbell
left a comment
There was a problem hiding this comment.
few small comments, not blocking 💯
Contributor
Author
|
@cjbell thanks for the feedback. I've implemented your suggestions in the latest commit |
cjbell
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.