Issues clean up

[paglias]

I've explored more or less every issue reported on Github and found out a lot of bugs that are already fixed, are only waiting to be merged from a lot of months... and I came out with a list of about 30 issues that can be closed/merged:

Issues that can be closed

• Jan/Feb 2013 iteration planning #787 Jan/Feb 2013 iteration planning -> All the items have been completed
• Take control of the "knockout" npm module #522 take control of knockout npm package -> control taken
• Out of browser support and test runner #751 Out of browser support and test runner -> implemented in the already merged Nodejs support #798
• Non-browser environment #712 Non-browser environment -> previous request of Out of browser support and test runner #751
• Value binding not updating when clicking outside the document in Chrome/WebKit #764 Value binding not updating when clicking outside the document in Chrome/WebKit -> not related to Knockout, we can do nothing on that
• ks.toJSON will randomly fail in IE8 #574 ks.toJSON will randomly fail in IE8 -> not Knockout's fault
• input[type=search] built in clear and valueupdate #576 input[type=search] built in clear and valueupdate -> Not a bug
• Add a component.json file, so Knockout.js can register with the Bower package manager #642 Add a component.json file, so Knockout.js can register with the Bower package manager -> discussed in Added a component.json for Twitter Bower. #646
• Added a stringContains method to utils.js #586 Added a stringContains method to utils.js -> there's a native method in javascript, see my comment to it
• npm package - client version possible? #526 npm package - client version possible? -> this will be fixed when we finish Paglias node package #866 and anyway Steve has already pushed a new version to NPM in the meantime
• ko.toJS and dates #55 ko.toJS and dates -> already fixed

Bug fixes that can be merged without any side effect

• fixes #733 #827 fixes observableArray accepting non-array value #733 (observable array accepting non-array value)
• fixes #560 #832 fixes Broken link in documentation #560 (a broken link in the documentation)
• fixes #691 #829 fixes remove duplicate specs for checked binding #691 (remove duplicate specs for checked binding)
• Guard against arbitrary objects being passed in on subscribe #555 Guard against arbitrary objects being passed in on subscribe
• fixes #703 IE 9 frame bug with hasfocus binding #828 fixes IE 9 frame bug with hasfocus binding #703 (IE 9 frame bug with hasfocus binding)
• add null and undefined to js reserved words, fixes #762 #871 add null and undefined to js reserved words, fixes Binding null causes exceptions in Firefox #762
• Replace stringTrimRegexp with a shorter and faster variant #611 Replace stringTrimRegexp with a shorter and faster variant

Changes that can be merged

• ko.toJS changes #833 ko.toJS changes (fixes toJS support for Number and String instances #577, ko.toJS() serialize every property including ordinal functions #251, ko.toJS(new Number(42)) gives unexpected results #524) -> more than a change it's a series of bug fixes, the only thing that could cause problems is that ko.toJS won't serialize anymore functions (ko.toJS() serialize every property including ordinal functions #251). But i think it's safe to merge it
• Added method 'pushAll' into observableArray #845 Added method 'pushAll' into observableArray (fixes Add ko.observableArray.fn.pushAll #416) -> This also hasn't any type of side effect
• Update to end comment regex to support the form <!-- /ko some more text --> #480 Update to end comment regex to support the form
• Allow 'options' binding on <datalist> element #720 Allow 'options' binding on <datalist> element

Here I've included only the ones I was sure about, there are others but I've preferred not to include them.

Also, I've noticed that a lot of issues are about the same bugs/feature requests, I think that when is possible we should try to track them in only one issue and close all the others.

[mbest]

Thanks, Matteo. This is really useful.

[mbest]

#616 binding failed in IE8 when attribute has no quotations, inside jquery template -> this is the only I'm not sure about, I think it could be closed since jQuery tmpl is no longer maintained. But since knockout still includes it maybe you want to try to fix it

I'm going to take this off the list because I think we should look into it first.