Skip to content

fix(tests): use this.skip() when cross-window popup is blocked #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianmhunt merged 2 commits into from
Apr 22, 2026
Merged

fix(tests): use this.skip() when cross-window popup is blocked #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c29892
fix(tests): use this.skip() when cross-window popup is blocked
Apr 22, 2026
708c287
fix(tests): drop skip() string arg — Mocha types are 0-arg
Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion builds/knockout/spec/crossWindowBehaviors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ describe('Cross-window support', function () {
var win2 = window.open('', '_blank', 'height=150,location=no,menubar=no,toolbar=no,width=250')

if (!win2) {
return
return this.skip('popup blocked — cross-window assertions cannot run')
}

var blankHtml = '<!doctype html><html><head></head><body></body></html>'
Expand Down
4 changes: 3 additions & 1 deletion packages/bind/spec/crossWindowBehaviors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ describe('Cross-window support', function () {
const win2 = window.open('', '_blank', 'height=150,location=no,menubar=no,toolbar=no,width=250')

if (!win2) {
return
// Popup blocked — skip so mocha reports pending (○) instead
// of silently passing with zero assertions.
return this.skip()
}

const previousTemplateEngine = nativeTemplateEngine.instance
Expand Down
Loading