chore: version packages (v4.1.0)#372
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (58)
💤 Files with no reviewable changes (4)
📝 WalkthroughWalkthroughVersion 4.1.0 release across the tko monorepo consolidates changeset metadata into package changelogs and bumps all package versions from 4.0.1 to 4.1.0, updating all inter-package dependencies accordingly. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR is the Changesets-generated “version packages” release PR for v4.1.0, updating the fixed-group package set from 4.0.1 → 4.1.0, writing per-package changelog entries, and removing the consumed changeset files.
Changes:
- Bump versions to
4.1.0across the fixed-group packages and update internal dependency ranges to^4.1.0. - Add
4.1.0entries to each affected package’sCHANGELOG.md. - Remove the four consumed
.changeset/*.mdfiles.
Reviewed changes
Copilot reviewed 58 out of 58 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/utils/package.json | Bump package + internal deps to 4.1.0 |
| packages/utils/CHANGELOG.md | Add 4.1.0 changelog entry |
| packages/utils.parser/package.json | Bump package + internal deps to 4.1.0 |
| packages/utils.parser/CHANGELOG.md | Add 4.1.0 changelog entry |
| packages/utils.jsx/package.json | Bump package + internal deps to 4.1.0 |
| packages/utils.jsx/CHANGELOG.md | Add 4.1.0 changelog entry (minor + dep bumps) |
| packages/utils.functionrewrite/package.json | Bump package to 4.1.0 |
| packages/utils.functionrewrite/CHANGELOG.md | Add 4.1.0 changelog header |
| packages/utils.component/package.json | Bump package + internal deps to 4.1.0 |
| packages/utils.component/CHANGELOG.md | Add 4.1.0 changelog entry (dep bumps) |
| packages/provider/package.json | Bump package + internal deps to 4.1.0 |
| packages/provider/CHANGELOG.md | Add 4.1.0 changelog entry (dep bumps) |
| packages/provider.virtual/package.json | Bump package + internal deps to 4.1.0 |
| packages/provider.virtual/CHANGELOG.md | Add 4.1.0 changelog entry (dep bumps) |
| packages/provider.native/package.json | Bump package + internal deps to 4.1.0 |
| packages/provider.native/CHANGELOG.md | Add 4.1.0 changelog entry (dep bumps) |
| packages/provider.mustache/package.json | Bump package + internal deps to 4.1.0 |
| packages/provider.mustache/CHANGELOG.md | Add 4.1.0 changelog entry (dep bumps) |
| packages/provider.multi/package.json | Bump package + internal deps to 4.1.0 |
| packages/provider.multi/CHANGELOG.md | Add 4.1.0 changelog entry |
| packages/provider.databind/package.json | Bump package + internal deps to 4.1.0 |
| packages/provider.databind/CHANGELOG.md | Add 4.1.0 changelog entry |
| packages/provider.component/package.json | Bump package + internal deps to 4.1.0 |
| packages/provider.component/CHANGELOG.md | Add 4.1.0 changelog entry (incl. triggerEvent note + dep bumps) |
| packages/provider.bindingstring/package.json | Bump package + internal deps to 4.1.0 |
| packages/provider.bindingstring/CHANGELOG.md | Add 4.1.0 changelog entry (dep bumps) |
| packages/provider.attr/package.json | Bump package + internal deps to 4.1.0 |
| packages/provider.attr/CHANGELOG.md | Add 4.1.0 changelog entry |
| packages/observable/package.json | Bump package + internal deps to 4.1.0 |
| packages/observable/CHANGELOG.md | Add 4.1.0 changelog entry |
| packages/lifecycle/package.json | Bump package + internal deps to 4.1.0 |
| packages/lifecycle/CHANGELOG.md | Add 4.1.0 changelog entry |
| packages/filter.punches/package.json | Bump package + internal deps to 4.1.0 |
| packages/filter.punches/CHANGELOG.md | Add 4.1.0 changelog entry (dep bumps) |
| packages/computed/package.json | Bump package + internal deps to 4.1.0 |
| packages/computed/CHANGELOG.md | Add 4.1.0 changelog entry (ko.proxy deleteProperty fix + dep bumps) |
| packages/builder/package.json | Bump package + internal deps to 4.1.0 |
| packages/builder/CHANGELOG.md | Add 4.1.0 changelog entry |
| packages/binding.template/package.json | Bump package + internal deps to 4.1.0 |
| packages/binding.template/CHANGELOG.md | Add 4.1.0 changelog entry (dep bumps) |
| packages/binding.if/package.json | Bump package + internal deps to 4.1.0 |
| packages/binding.if/CHANGELOG.md | Add 4.1.0 changelog entry (dep bumps) |
| packages/binding.foreach/package.json | Bump package + internal deps to 4.1.0 |
| packages/binding.foreach/CHANGELOG.md | Add 4.1.0 changelog entry |
| packages/binding.core/package.json | Bump package + internal deps to 4.1.0 |
| packages/binding.core/CHANGELOG.md | Add 4.1.0 changelog entry (incl. triggerEvent note + dep bumps) |
| packages/binding.component/package.json | Bump package + internal deps to 4.1.0 |
| packages/binding.component/CHANGELOG.md | Add 4.1.0 changelog entry (dep bumps) |
| packages/bind/package.json | Bump package + internal deps to 4.1.0 |
| packages/bind/CHANGELOG.md | Add 4.1.0 changelog entry (dep bumps) |
| builds/reference/package.json | Bump build package + internal deps to 4.1.0 |
| builds/reference/CHANGELOG.md | Add 4.1.0 changelog entry (dep bumps) |
| builds/knockout/package.json | Bump build package + internal deps to 4.1.0 |
| builds/knockout/CHANGELOG.md | Add 4.1.0 changelog entry (dep bumps) |
| .changeset/modernize-utils-dead-polyfills.md | Remove consumed changeset |
| .changeset/modernize-trigger-event.md | Remove consumed changeset |
| .changeset/fix-proxy-delete-property.md | Remove consumed changeset |
| .changeset/fix-jsx-clean-teardown-race.md | Remove consumed changeset |
| - `stringTrim` + `stringStartsWith` — call sites use `String(value ?? '') | ||
| .trim()` / `value.startsWith(prefix)` inline. Both names remain exported |
There was a problem hiding this comment.
The inline code for the string trim example is split across two lines (backtick opens on the previous line and closes after .trim()), which breaks Markdown rendering. Please keep String(value ?? '').trim() on a single line so the code span is valid.
| - `stringTrim` + `stringStartsWith` — call sites use `String(value ?? '') | |
| .trim()` / `value.startsWith(prefix)` inline. Both names remain exported | |
| - `stringTrim` + `stringStartsWith` — call sites use `String(value ?? '').trim()` / `value.startsWith(prefix)` inline. Both names remain exported |
| - `stringTrim` + `stringStartsWith` — call sites use `String(value ?? '') | ||
| .trim()` / `value.startsWith(prefix)` inline. Both names remain exported | ||
| from `@tko/utils` as inline passthroughs. |
There was a problem hiding this comment.
The inline code for the string trim example is split across two lines (backtick opens on the previous line and closes after .trim()), which breaks Markdown rendering. Please keep String(value ?? '').trim() on a single line so the code span is valid.
| - `stringTrim` + `stringStartsWith` — call sites use `String(value ?? '') | |
| .trim()` / `value.startsWith(prefix)` inline. Both names remain exported | |
| from `@tko/utils` as inline passthroughs. | |
| - `stringTrim` + `stringStartsWith` — call sites use `String(value ?? '').trim()` | |
| / `value.startsWith(prefix)` inline. Both names remain exported from | |
| `@tko/utils` as inline passthroughs. |
| - `stringTrim` + `stringStartsWith` — call sites use `String(value ?? '') | ||
| .trim()` / `value.startsWith(prefix)` inline. Both names remain exported |
There was a problem hiding this comment.
The inline code for the string trim example is split across two lines (backtick opens on the previous line and closes after .trim()), which breaks Markdown rendering. Please keep String(value ?? '').trim() on a single line so the code span is valid.
| - `stringTrim` + `stringStartsWith` — call sites use `String(value ?? '') | |
| .trim()` / `value.startsWith(prefix)` inline. Both names remain exported | |
| - `stringTrim` + `stringStartsWith` — call sites use `String(value ?? '').trim()` / `value.startsWith(prefix)` inline. Both names remain exported |
| ### Patch Changes | ||
|
|
||
| - @tko/bind@4.1.0 | ||
| - @tko/provider.bindingstring@4.1.0 | ||
|
|
There was a problem hiding this comment.
The 4.1.0 changelog entry lists dependency bumps as top-level bullets, which is inconsistent with this repo’s existing changelog format in the same file (e.g., prior entries use “Updated dependencies […]” with an indented list). Consider switching this section to the established “Updated dependencies […]” format for consistency and readability.
| ## 4.1.0 | ||
|
|
||
| ## 4.0.1 |
There was a problem hiding this comment.
The 4.1.0 changelog section is currently empty (no “Patch Changes”/“Updated dependencies” bullets). Since the package version is being bumped, please add an entry consistent with the other packages (even if it’s just an “Updated dependencies” note) so the release notes aren’t blank.
| - `stringTrim` + `stringStartsWith` — call sites use `String(value ?? '') | ||
| .trim()` / `value.startsWith(prefix)` inline. Both names remain exported |
There was a problem hiding this comment.
The inline code for the string trim example is split across two lines (backtick opens on the previous line and closes after .trim()), which breaks Markdown rendering. Please keep String(value ?? '').trim() on a single line so the code span is valid.
| - `stringTrim` + `stringStartsWith` — call sites use `String(value ?? '') | |
| .trim()` / `value.startsWith(prefix)` inline. Both names remain exported | |
| - `stringTrim` + `stringStartsWith` — call sites use `String(value ?? '').trim()` | |
| / `value.startsWith(prefix)` inline. Both names remain exported |
| - `stringTrim` + `stringStartsWith` — call sites use `String(value ?? '') | ||
| .trim()` / `value.startsWith(prefix)` inline. Both names remain exported | ||
| from `@tko/utils` as inline passthroughs. |
There was a problem hiding this comment.
The inline code for the string trim example is split across two lines (backtick opens on the previous line and closes after .trim()), which breaks Markdown rendering. Please keep String(value ?? '').trim() on a single line so the code span is valid.
| ### Patch Changes | ||
|
|
||
| - @tko/bind@4.1.0 | ||
| - @tko/provider@4.1.0 | ||
|
|
There was a problem hiding this comment.
The 4.1.0 changelog entry lists dependency bumps as top-level bullets, which is inconsistent with this repo’s existing changelog format in the same file (e.g., prior entries use “Updated dependencies […]” with an indented list). Consider switching this section to the established “Updated dependencies […]” format for consistency and readability.
| ### Patch Changes | ||
|
|
||
| - @tko/provider@4.1.0 | ||
|
|
There was a problem hiding this comment.
The 4.1.0 changelog entry lists the dependency bump as a top-level bullet. In this repo’s prior entries for this package, dependency bumps are recorded under an “Updated dependencies […]” bullet with an indented list. Consider using the same structure here for consistency.
| - `stringTrim` + `stringStartsWith` — call sites use `String(value ?? '') | ||
| .trim()` / `value.startsWith(prefix)` inline. Both names remain exported | ||
| from `@tko/utils` as inline passthroughs. |
There was a problem hiding this comment.
The inline code for the string trim example is split across two lines (backtick opens on the previous line and closes after .trim()), which breaks Markdown rendering. Please keep String(value ?? '').trim() on a single line (and similarly for the startsWith example) so the code span is valid.
Summary
Auto-generated by
changesets/action@v1from the four pending changesets, then opened by hand because the action's PR-creation step skipped under a tag-push trigger (it produced the branch correctly — the tag ref leaks into the branch name, which is the symptom).Bumps every fixed-group package from
4.0.1→4.1.0and writes per-packageCHANGELOG.mdentries. Consumes:fix-jsx-clean-teardown-race— addsoptions.jsxCleanBatchSizefix-proxy-delete-property— fixesko.proxydeletePropertytrap signaturemodernize-trigger-event—triggerEventuses nativeMouseEvent/KeyboardEventconstructorsmodernize-utils-dead-polyfills— drops dead polyfill probes; public API preserved as@deprecatedpassthroughs inpackages/utils/src/compat.tsResult
4.1.0Release flow
After merging this PR, force-move the
v4.1.0tag to the merge commit and push:That re-triggers
release.yml, which now sees no pending changesets and runs thepublishjob (npm publish via OIDC trusted publishing) and thegithub-releasejob.Test plan
package.jsonshows"version": "4.1.0"CHANGELOG.mdentries writtenGenerated by Claude Code
Summary by CodeRabbit
New Features
options.jsxCleanBatchSizeto control JSX node cleanup batching, including synchronous cleanup mode.Bug Fixes
ko.proxydeleteProperty behavior to correctly remove properties from proxied objects.Refactor
Chores