Skip to content

docs: use bunx @playwright/cli in AGENTS.md and process.md#391

Merged
brianmhunt merged 1 commit into
mainfrom
claude/playwright-cli-fix
May 28, 2026
Merged

docs: use bunx @playwright/cli in AGENTS.md and process.md#391
brianmhunt merged 1 commit into
mainfrom
claude/playwright-cli-fix

Conversation

@brianmhunt
Copy link
Copy Markdown
Member

Replace bare playwright-cli references with bunx @playwright/cli (the correct invocation for @playwright/cli v0.1.13). Also drop the prohibition framing from AGENTS.md β€” just state what to use.

https://claude.ai/code/session_01VXbxD98AzZ8pLfN2JmBeuE


Generated by Claude Code

Replace bare playwright-cli with the correct invocation. Drop the
prohibition framing from AGENTS.md β€” just state what to use.

https://claude.ai/code/session_01VXbxD98AzZ8pLfN2JmBeuE
Copilot AI review requested due to automatic review settings May 28, 2026 14:37
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Review Change Stack

No actionable comments were generated in the recent review. πŸŽ‰

ℹ️ Recent review info
βš™οΈ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6a3b55b0-357a-4ea3-aa34-7550909bc27c

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 32c7e0c and 3614f43.

πŸ“’ Files selected for processing (2)
  • AGENTS.md
  • tko.io/public/agents/process.md

πŸ“ Walkthrough

Walkthrough

Both documentation files are updated to use bunx @playwright/cli`` for Playwright browser automation. AGENTS.md updates the agent guidance for browser automation, and tko.io/public/agents/process.md updates the verification workflow while preserving all surrounding verification steps and checks.

Changes

Playwright CLI Invocation

Layer / File(s) Summary
Playwright CLI invocation guidance
AGENTS.md, tko.io/public/agents/process.md
Both agent guidance and verification workflow docs update Playwright command invocation to use bunx @playwright/cli`` instead of direct playwright or `playwright-cli` references. Surrounding verification instructions for dev-server and playground validation remain intact.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • knockout/tko#351: Both PRs modify the Playwright-based verification checklist in tko.io/public/agents/process.md; this PR switches to bunx @playwright/cli``, while the retrieved PR updates status/error selectors to [data-role="…"].

Poem

🐰 A hop, a skip, through docs we go,
Where bunx @playwright/cli`` steals the show,
From ancient playwright to shiny new,
Your agent guides now verified true! 🎭

πŸš₯ Pre-merge checks | βœ… 5
βœ… Passed checks (5 passed)
Check name Status Explanation
Description Check βœ… Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check βœ… Passed The title accurately describes the main change: updating documentation in AGENTS.md and process.md to use bunx @playwright/cli instead of previous Playwright invocation methods.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/playwright-cli-fix

Warning

Review ran into problems

πŸ”₯ Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’‘ Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3614f4380c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- Prefer a live Astro dev server on `127.0.0.1:4321` so markdown/plugin edits reload while you work (`bun run dev` in `tko.io/`).
- Verify each `Open in Playground` button on the page; if a page has multiple TSX examples, check every one, not just the first.
- Standard flow: `playwright-cli close-all`, `playwright-cli open http://127.0.0.1:4321/...`, inspect the snapshot for playground refs, click each button, switch to the playground tab, and confirm `[data-role="status"]` (shows "esbuild ready"), `[data-role="compile-time"]`, and `[data-role="error-bar"]`.
- Standard flow: `bunx @playwright/cli close-all`, `bunx @playwright/cli open http://127.0.0.1:4321/...`, inspect the snapshot for playground refs, click each button, switch to the playground tab, and confirm `[data-role="status"]` (shows "esbuild ready"), `[data-role="compile-time"]`, and `[data-role="error-bar"]`.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Run the package's playwright-cli binary via bunx

For docs verification, these examples need to invoke the binary that @playwright/cli actually exposes. I checked Bun's bunx docs, which direct using --package <pkg> when the binary name differs from the package name, and @playwright/cli's package.json declares only the playwright-cli bin; in that context, bunx @playwright/cli close-all misleads agents into running a non-existent @playwright/cli executable instead of closing/opening the browser session. Use a form like bunx -p @playwright/cli playwright-cli close-all/open ... here and in the general AGENTS.md guidance.

Useful? React with πŸ‘Β / πŸ‘Ž.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates agent-facing documentation to use the bunx @playwright/cli invocation for Playwright browser automation.

Changes:

  • Replaces the AGENTS.md browser automation command with bunx @playwright/cli <cmd>.
  • Updates the detailed docs verification workflow to use bunx @playwright/cli.
  • Keeps the headless/docs verification guidance otherwise unchanged.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
AGENTS.md Updates the prerequisite guidance for browser automation command usage.
tko.io/public/agents/process.md Updates the detailed headless Playwright docs verification commands.

Comment thread AGENTS.md
- Use `bun install` instead of `npm install`; `bunx` instead of `npx`.
- In repo scripts (`tko.io/scripts`, `tools/`), prefer native Bun APIs β€” `Bun.Glob`, `Bun.file`, `Bun.write`, `Bun.$` β€” over `node:fs`, the `glob` export from `node:fs/promises`, or ad-hoc `child_process`. Runtime is pinned by `.tool-versions`, so there's no Node-version portability concern.
- Browser automation uses `bunx playwright <cmd>` via the repo's `playwright` dependency (not `npx playwright`, not the deprecated `playwright-cli` package).
- Browser automation uses `bunx @playwright/cli <cmd>`.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

@brianmhunt brianmhunt merged commit 03d1f67 into main May 28, 2026
11 checks passed
@brianmhunt brianmhunt deleted the claude/playwright-cli-fix branch May 28, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants