Support for origin field

[rgillan]

The current library does not support the WebSocket "origin" field as per the RFC, any way this can be added?

[rgillan]

If possible, this should be passed as the third parameter to the establishment [url, subprotocol, origin]

[knowledgecode]

Hi, rgillan.
I have understood the problems you had pointed.
But I'm busy right now. I want you to wait a little.

[rgillan]

We have simply added:

client.setOrigin(origin)

and verified that it does indeed set the origin in the outbound request headers, we just need to pass this through in the create call.

[knowledgecode]

Thank you for the advice.
If you please, fork my repository on github. Then you can edit all sources.

[knowledgecode]

I added the origin field by way of experimental.
How does that sound ?

[rgillan]

Thanks, will test later today

Please excuse brevity and spelling, sent from my phone.

Cheers
Rob

On 01/05/2013, at 1:31 AM, knowledgecode notifications@github.com wrote:

I added the origin field by way of experimental.
How does that sound ?

—
Reply to this email directly or view it on GitHub.

[rgillan]

Hi,

For non browser use, you really want the origin to be settable and passed through the create call arguments, which become URL, subprotocol, origin, not derived from the URL as you have done

Please excuse brevity and spelling, sent from my phone.

Cheers
Rob

On 01/05/2013, at 1:31 AM, knowledgecode notifications@github.com wrote:

I added the origin field by way of experimental.
How does that sound ?

—
Reply to this email directly or view it on GitHub.

[knowledgecode]

I see, but is this the only way ?
I have not wanted to add the third parameter to constructor much.
If there is no other way, I will do so....
Or if you have begun to make changes in the sources, I will wait.

[rgillan]

Hi,

Just forked but no changes as yet. All of the other WebSocket libraries used on mobile devices (Android and iOS) usually all allow each of the creation params to be passed through the constructor/call. This gives the greatest flexibility, and in our specific case we need to set the origin to be something other than the url, as we use it as part of our security model.

Thanks for helping with this,
Rob

Rob Gillan
Chief Technology Officer
Dzhon Pty Ltd
+61 3 9008 5668 ext 100
+61 402 332 087
rob@dzhon.com (email/voip/im)
www.dzhon.com

On 01/05/2013, at 4:26 PM, knowledgecode wrote:

I see, but is this the only way ?
I have not wanted to add the third parameter to constructor much.
If there is no other way, I will do so....
Or if you have begun to make changes in the sources, I will wait.

—
Reply to this email directly or view it on GitHub.

[knowledgecode]

Hi,
I added the third parameter to the WebSocket constructor.
Meet your expectations this time?

[rgillan]

Looks good, will test today and let you know. Thanks for all your help with this.

[knowledgecode]

Hi,
After that, what kind of situation are you in?
If there is no problem, I'd like to close this. Or shall I wait a little more?

[rgillan]

No, you can close this thank you. Works well.

Independently, we also tested wss (even before you last changes) and it works well.

Thanks for being so helpful on this

Cheers
Rob

Rob Gillan
Chief Technology Officer
Dzhon Pty Ltd
+61 3 9008 5668 ext 100
+61 402 332 087
rob@dzhon.com (email/voip/im)
www.dzhon.com

On 06/05/2013, at 7:48 PM, knowledgecode wrote:

Hi,
After that, what kind of situation are you in?
If there is no problem, I'd like to close this. Or shall I wait a little more?

—
Reply to this email directly or view it on GitHub.