Skip to content

Initial evaluation form#100

Merged
3mcd merged 7 commits into
mainfrom
gs/evaluation-form
Sep 19, 2023
Merged

Initial evaluation form#100
3mcd merged 7 commits into
mainfrom
gs/evaluation-form

Conversation

@gabestein
Copy link
Copy Markdown
Member

@gabestein gabestein commented Sep 14, 2023

Issue(s) Resolved

Partially resolves #57.

  • Fixes a small bug in the read integration API endpoint.
  • Adds a temporary "evaluate" action that allows devs to see an evaluation form
  • Adds a mock evaluation form that grabs single Pub's data from the integration read API

Test Plan

Screenshots (if applicable)

Optional

Notes/Context/Gotchas

Supporting Docs

Comment thread integrations/evaluations/app/actions/evaluate/page.tsx Outdated
Comment thread packages/sdk/src/client.ts Outdated
@gabestein gabestein changed the title [Draft] Initial evaluation form Initial evaluation form Sep 19, 2023
@isTravis isTravis temporarily deployed to gs/evaluation-form - core PR #100 September 19, 2023 14:42 — with Render Destroyed
@isTravis isTravis temporarily deployed to gs/evaluation-form - integration-submissions PR #100 September 19, 2023 14:42 — with Render Destroyed
@gabestein gabestein requested a review from 3mcd September 19, 2023 14:43
@gabestein
Copy link
Copy Markdown
Member Author

Thanks! I've fixed those issues, I think it's mergable for now, and I'll move on to testing out typing as discussed yesterday.

@3mcd 3mcd merged commit 6c7e196 into main Sep 19, 2023
@3mcd 3mcd deleted the gs/evaluation-form branch September 19, 2023 14:45
@gabestein gabestein mentioned this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automate forms from jsonschemas

3 participants