Fix related pubs bug

[allisonking]

Issue(s) Resolved

Closes #1003

High-level Explanation of PR

Our pub editor requires a list of pubs in a context so that it knows what pubs can be related to, and so it can render the titles of pubs that are already related. The problem is that when we query for pubs, we need to limit (in this case we limit to 30). So a pub might be related to another pub that is not in that initial 30, in which case the app can't render the pub's title since it wasn't returned with the query and breaks.

This fixes this initial problem by concatenating an existing pub's related pubs to the pubs sent to the pub context.

Test Plan

1. Add a relation field (can be null)
2. Add this field to a pubtype (i.e. Evaluation)
3. Add this field to the pubtype's default form too
4. Open an existing Evaluation pub (or create a new one)
5. Create a related pub via the "Add Related Pub" button on the Evaluation pub
6. Fill in any info to create the pub
7. Now add one more pub of any type (this is just to put the created related pub out of range)
8. Change the limit to 1
   https://github.com/pubpub/platform/blob/626e97e310537e74eeb8a77289514b7319d96d83/core/app/components/pubs/PubEditor/PubEditor.tsx#L166
9. Open the pub in step 4
10. Click "Update"
11. The pub should still render properly

Screenshots (if applicable)

Notes

[allisonking]

this originally came from #980 but it seems like just the flex-1 is enough to keep the width. adding prose changes a bunch of styles, including making <hr/>s have huge margins

prose is used for markdown, but I believe the various markdown places already have prose on them, i.e. StructuralElement
https://github.com/pubpub/platform/blob/0711707979fe1bc51874d120e33d6626b3f7be32/core/app/components/FormBuilder/FormElement.tsx#L167

[allisonking]

I just noticed it was still saying to fill out a field if the schema was null (and then it wouldn't render an input to fill out)

[allisonking]

TIL: you can use flatMap to get around how doing a .map(...).filter(value => !!value) doesn't let TS think you have Thing[] and TS will still think you have (Thing | null)[] even after the filter

https://stackoverflow.com/a/59726888

[kalilsn]

very hot tip, the .filter typing is so annoying!

[tefkah]

i think they did fix this in a recent release, if you do .filter(value=>value != null) specifically!

[tefkah]

oh no nvm, this only applies one level deep! they fixed the "simple" case in typescript 5.5

https://devblogs.microsoft.com/typescript/announcing-typescript-5-5/#inferred-type-predicates

Example (change to typescript <5.5 to see error in the simple case)

https://www.typescriptlang.org/play/?target=99&pretty=true&allowSyntheticDefaultImports=true&preserveValueImports=true&isolatedModules=true&verbatimModuleSyntax=false&ts=5.5.4&ssl=1&ssc=1&pln=2&pc=1#code/C4TwDgpgBAwg9gWzAGwgDwCoAsCWA7AcygF4oBvKLCEALnMrjoHIrlk4omBfKAHyjwBXNlwBQoSFADKOJKmz4ipClVqdW7JlB78hbUQBMIAY2QBDAE7RjcPAGdgUG3PR0AFPBeZchAJQBtAF1DE3MrJ1sHKDtZFAg6GRcFQiDRURt7R2cwEgivADoAMxxkYAgLNwA3YgA+SvzVKABCUj1kX1FURys7XOz-AAZAhuoGjlEAegmoGagAPQB+KDSMqJikXPW4opKyiuqapqbKjq6oHoAmTdjB4dVJ6dnFqCA

[kalilsn]

Works great! Tested and confirmed the bug on main (with limit 1) and that it works on your branch