feat: allow users to sign up and fill out public forms by tefkah · Pull Request #1114 · knowledgefutures/pubplatform

tefkah · 2025-03-26T17:26:03Z

Issue(s) Resolved

Resolves #1053
Resolves #1051

High-level Explanation of PR

There is now the possibility for people to sign up to communities without being invited.

Communities that have at least one public form now automatically enable signups at /c/{communitySlug}/public/signup. There currently is no way to disable this aside from settings your forms to private.

Users who go to a public form, will now be redirected to the signup page, where they can sign up to the community. Once complete, they will be redirected to the form they tried to access.

Separately from all this: once a user creates a pub using the PubEditor, they will be added as a Contributor to the pub. This allows the user to see the pub in the pub list.

This PR also removes the "Invite Only" access type. Forms which were set to this will be set to private instead.

Extra credits

Redirect to the created pub

Currently there is no easy way to direct the user to their created pub. I added a new option to the :link token that allows you to link to a pub. It goes like :link(page='currentPub' text='View your pub'). This will link to the pub that the user just created. By setting the postsubmit screen like i do here

https://github.com/pubpub/platform/blob/1e622788da94c05597f27a586f5df2040bd40bea/core/playwright/formAccess.spec.ts#L126-L131

the user will see a screen like this (note how it links to a direct pub)

We should probably have some redirect action instead, see #1115 for more details.

Nicer button

I added a button that automatically does broadly correct loading state showing, see:

Screen.Recording.2025-03-27.at.19.55.02.mov

The code is here:

https://github.com/pubpub/platform/blob/8b86f1f18dd978de78d5622e7c0ede14d322066c/core/app/components/SubmitButton.tsx#L1-L176

I think it's nice and we should use it in more places.

Test Plan

As always, convince yourself of the truth and accuracy of the added tests.

Go to https://pr-1114-public-form-u-ip-54-221-104-228.my.preview.run/c/croccroc/public/forms/review/fill while not logged in.
Be presented with the signup form, create an account.
You should be redirected back to the form.
Fill out form and submit.
Click the link
See that you are redirected to your pub, and see that you are a contributor.

Do maybe the same again after changing the form to private (and logging out). You should not be able to see the form/signup page at all.

Screenshots (if applicable)

Demo:

Screenshare.-.2025-03-27.8_21_16.PM.mp4

I changed the spacing of button config form from this

to this

Notes

github-actions · 2025-03-26T17:27:48Z

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-04-03 16:31 UTC

…wn tokens

tefkah · 2025-03-27T19:26:33Z

please add to this when you encounter an issue!

tefkah · 2025-03-27T19:27:37Z

ideally we would define most errors for server actions like this i think, rather than having a bunch of random return { error: 'xxxx' } everywhere

tefkah · 2025-03-27T19:28:46Z

i thought i wanted to use this in a playwright test (to do a rollback), which is why i moved it. didn't actually want to turns out, bc if you update things in a transaction, ofc the app will not reflect those changes before you commit

tefkah · 2025-03-27T19:29:49Z

+
+	const handleSubmit = useCallback(
+		async (data: SignupFormSchema) => {
+			// TODO: this is not very nice UX, we should wait a sec and show a loading state


since the signup function already redirected users i didn't really want to change it, but we should figure out some nice pattern here

tefkah · 2025-03-27T19:30:55Z

this is the signup form for users who are invited using the email action to complete their signup. i think we should phase this out and handle those invites the same as invites where we do not create an account yet (#1002)

tefkah · 2025-03-27T19:31:46Z

users who are already logged in should not sign up again, they can just join the community immediately.
both this and the signup form (or just that page) should show some branding in the future.

tefkah · 2025-03-27T19:32:38Z

-	[FormAccessType.inviteOnly]: {
-		Icon: Contact,
-		description: "Accessible via URL with tracked submissions",
-		name: "Invite Only",
-		help: "Community members & invited contributors can submit",
-	},


As per the extra work in #1051 , we now only have private and public forms

tefkah · 2025-03-27T19:33:23Z

this logic is getting very complex. in my next pr i will create some kind of centralized place to handle this, like a Service class or something

tefkah · 2025-03-27T19:33:49Z

 	"display": "Next.js",
 	"extends": "./base.json",
 	"compilerOptions": {
-		"plugins": [{ "name": "next" }],


this removal doesn't really do anything other than make me feel better.

allisonking · 2025-04-02T14:24:36Z

+	type?: "button" | "submit" | "reset";
+};
+
+export const SubmitButton = ({


allisonking · 2025-04-02T15:23:14Z

I tested using the preview environment, though I wasn't able to see the pub once I hit submit on the form. I saw the 'Go see your pubs here' link, and clicked here, but then got redirected to sign in. I tried to sign in but it didn't work (this might just be because I didn't remember my temp password right). the pub I made is there though: https://pr-1114-public-form-u-ip-54-221-104-228.my.preview.run/c/croccroc/pubs/84e66eea-563f-4c2c-ba90-fcfd1f781cea

I'll try locally too to see if maybe it's just something is up with the preview env

allisonking · 2025-04-02T15:30:32Z

well it seems to work locally! although I can't seem to change a form to private so haven't been able to test the 'no forms should show up' state yet

Screen.Recording.2025-04-02.at.11.28.26.AM.mov

tefkah · 2025-04-03T10:37:40Z

huh that's strange, ill have a look!

tefkah · 2025-04-03T13:31:17Z

The "not being able to change access types" is a bug in the formbuilder, you need to change something else about the form in order for it to change. ill put up a quick pr which addresses that (and some other thing), but i don't want this pr to be even bigger!

allisonking

ah okay great! I confirmed that I can make private if I also add another form element, and then the not-signed-in user can't see it 👍 nice work!

sentry · 2025-04-08T19:52:00Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️ Error: Unexpected link variant serverAction/ View Issue

_{Did you find this useful? React with a 👍 or 👎}

tefkah added 17 commits March 18, 2025 18:19

first bad pass

1889e7d

chore: merge

d62f2b5

feat: add invite table

827ca4c

refactor: split up the signup code somewhat

95d6d81

refactor: split up signup form into three forms

7e0ccdf

refactor: move public signup form to different place, do some checks

19304b2

feat: add public join page

437e87d

fix: export invites

8ecd5aa

feat: add public signup stuff

a90dda3

chore: merge

6b59061

feat: creaet happy path for unauthed signup

36e152d

feat: add user to pub after creation

dbee4c3

docs: add warning about foreign key issues

766df14

chore: add todo comment

5fd5b8b

fix: set correct type for subitbuttons stageid

7e50b0f

fix: set correct type for stageId

2cb474e

fix: no justify between for button formbuilder form

cb9d39d

tefkah added 12 commits March 26, 2025 18:28

fix: do not check authentication in public layout

0ee2557

refactor: move join page to community signup page and make it work

741bc0d

refactor: auto log signup errors

a57ed77

dev: add a bunch of tests for the public form

4c57700

chore: remove signup service experiment

04d34e2

chore: remove next plugin bc it crashes vscode

0a65544

dev: fix tests by adding formcontrols around inputs

20b83ab

fix: actually remove next plugin

9053549

fix: write some docs on how to deal with next's bullshit

dfed56c

feat: add ability to link to current pub and other places with markdo…

dd433ab

…wn tokens

dev: more tests!

50bc7c6

chore: update test

4c19832

tefkah commented Mar 27, 2025

View reviewed changes

Comment thread docs/content/development/common-issues.mdx

Copy link
Copy Markdown

Member Author

tefkah Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add to this when you encounter an issue!

tefkah commented Mar 27, 2025

View reviewed changes

3mcd temporarily deployed to gh-654103159-pr-1114 March 27, 2025 19:27 Inactive

tefkah commented Mar 27, 2025

View reviewed changes

This was referenced Mar 27, 2025

Verify user emails after signup #1121

Closed

Application-level rate limiting for signups and login attempts #1122

Open

tefkah added 2 commits April 1, 2025 15:42

fix: remove invite table for now

af18745

Merge branch 'main' into tfk/public-form-users

343aeb8

3mcd temporarily deployed to gh-654103159-pr-1114 April 1, 2025 13:48 Inactive

chore: merge

ca84e1f

3mcd temporarily deployed to gh-654103159-pr-1114 April 2, 2025 09:49 Inactive

allisonking reviewed Apr 2, 2025

View reviewed changes

allisonking approved these changes Apr 3, 2025

View reviewed changes

Merge branch 'main' into tfk/public-form-users

23aa0b0

3mcd had a problem deploying to gh-654103159-pr-1114 April 3, 2025 16:15 Error

3mcd merged commit b76526c into main Apr 3, 2025

3mcd deleted the tfk/public-form-users branch April 3, 2025 16:31

This was referenced Jul 10, 2025

Add public form access behavior and ability to create new user #601

Closed

Allow users to create account via forms #713

Closed

Conversation

tefkah commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue(s) Resolved

High-level Explanation of PR

Extra credits

Redirect to the created pub

Nicer button

Test Plan

Screenshots (if applicable)

Notes

Uh oh!

github-actions Bot commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

allisonking commented Apr 2, 2025

Uh oh!

allisonking commented Apr 2, 2025

Uh oh!

tefkah commented Apr 3, 2025

Uh oh!

tefkah commented Apr 3, 2025

Uh oh!

allisonking left a comment

Choose a reason for hiding this comment

Uh oh!

sentry Bot commented Apr 8, 2025

Suspect Issues

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tefkah commented Mar 26, 2025 •

edited

Loading

github-actions Bot commented Mar 26, 2025 •

edited

Loading