Skip to content

Add all evaluation fields#138

Merged
gabestein merged 27 commits into
mainfrom
gs/unjournal-eval-form
Nov 6, 2023
Merged

Add all evaluation fields#138
gabestein merged 27 commits into
mainfrom
gs/unjournal-eval-form

Conversation

@gabestein
Copy link
Copy Markdown
Member

@gabestein gabestein commented Oct 16, 2023

Issue(s) Resolved

#57

So I went off the deep end on dereferencing and this is far from perfect. But it works pretty well, and I think sets us up well in the future.

  • Outputs a complete auto-generated form for unjournal evaluations that includes dynamic, synchronous dereferencing of local schema refs! See comments for places where bad stuff happens that could be improved.
  • Cleans up the layout of the form.
  • Add a pretty effing cool custom renderer for confidence intervals (with a very bad/naive system for choosing renderers -- we still need to do some work here, but the actual component is pretty good)
  • Adds a really poorly designed form header that gives the author information about the unjournal. This really could be made better -- we could probably even use Qwelian's code for displaying Pubs here instead of my dumb stuff #IANAD

Test Plan

  1. Submit a pub
  2. Move to under evaluation
  3. Invite yourself
  4. Fill out form
  5. Pull up Pub in prisma studio and bask in the glory of your submitted pub
  6. Bonus: try a Pub other than the evaluation type and make sure it still works

Screenshots (if applicable)

Optional

Notes/Context/Gotchas

Still to do (but not blocking):

  • Better design for the header
  • Pull in submitted data from pub as default values
  • Ordering in multi-field schemas
  • Add required elements to seed script
  • Make the compiled schema stuff a little safer
  • Make custom rendering a little better than just if statements
  • Get excluded/mapped fields in integration instance settings rather than hardcoding
  • Get instructions text from integration instance settings

Supporting Docs

This commit creates local db accounts for any user that
successfully authenticates with supabase. It also attempts to use the
supabase user_metadata to find the user's name.
@isTravis isTravis temporarily deployed to gs/unjournal-eval-form - flock PR #138 November 2, 2023 20:00 — with Render Destroyed
@isTravis isTravis temporarily deployed to gs/unjournal-eval-form - core PR #138 November 2, 2023 20:00 — with Render Destroyed
@isTravis isTravis temporarily deployed to gs/unjournal-eval-form - integration-evaluations PR #138 November 2, 2023 20:00 — with Render Destroyed
@isTravis isTravis temporarily deployed to gs/unjournal-eval-form - integration-submissions PR #138 November 2, 2023 20:00 — with Render Destroyed
@gabestein gabestein requested a review from 3mcd November 2, 2023 20:01
@isTravis isTravis temporarily deployed to gs/unjournal-eval-form - flock PR #138 November 6, 2023 18:19 — with Render Destroyed
@isTravis isTravis temporarily deployed to gs/unjournal-eval-form - core PR #138 November 6, 2023 18:19 — with Render Destroyed
@isTravis isTravis temporarily deployed to gs/unjournal-eval-form - integration-evaluations PR #138 November 6, 2023 18:19 — with Render Destroyed
@isTravis isTravis temporarily deployed to gs/unjournal-eval-form - integration-submissions PR #138 November 6, 2023 18:19 — with Render Destroyed
@gabestein gabestein merged commit acad8c2 into main Nov 6, 2023
@gabestein gabestein deleted the gs/unjournal-eval-form branch November 6, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants