Skip to content

Fix signup issues#160

Merged
kalilsn merged 5 commits into
mainfrom
kalilsn/signup-fixes
Nov 2, 2023
Merged

Fix signup issues#160
kalilsn merged 5 commits into
mainfrom
kalilsn/signup-fixes

Conversation

@kalilsn
Copy link
Copy Markdown
Contributor

@kalilsn kalilsn commented Nov 2, 2023

Fixes:

  • Invite script was failing due to importing seed script
  • Improved the invite flow to use the actual invite method in supabase rather than a password reset. This way seems to actually redirect to the community after setting a password!
  • Fixes an issue preventing login with the all@pubpub.org user. But we probably shouldn't really use that user for testing any more since that's not how our real users (unjournal staff) are being created.

Test Plan

I'll send some invites to the team. And try signing in locally with the pubpub-all user after a reset and it should work.

Screenshots (if applicable)

Optional

Notes/Context/Gotchas

Supporting Docs

@3mcd
Copy link
Copy Markdown
Collaborator

3mcd commented Nov 2, 2023

Just tried to reset my password using the link in the email and got this:

image

No console errors, network errors (or requests for that matter) occur when the "Set new password" button is pressed.

Probably unrelated warnings in console:

image

@kalilsn
Copy link
Copy Markdown
Contributor Author

kalilsn commented Nov 2, 2023

@3mcd I think there's an error in the URL there, and it looks somewhat like the error that Jake reported to me - but how could it have expired already?

I checked in supabase and we have these emails set to expire after 24hours
image

@kalilsn
Copy link
Copy Markdown
Contributor Author

kalilsn commented Nov 2, 2023

@3mcd if you visit https://v7.pubpub.org/forgot does the new email from that work for you?

@isTravis isTravis temporarily deployed to kalilsn/signup-fixes - flock PR #160 November 2, 2023 22:10 — with Render Destroyed
@isTravis isTravis temporarily deployed to kalilsn/signup-fixes - integration-submissions PR #160 November 2, 2023 22:10 — with Render Destroyed
@isTravis isTravis temporarily deployed to kalilsn/signup-fixes - integration-evaluations PR #160 November 2, 2023 22:10 — with Render Destroyed
@isTravis isTravis temporarily deployed to kalilsn/signup-fixes - core PR #160 November 2, 2023 22:10 — with Render Destroyed
@kalilsn kalilsn merged commit 55cdee9 into main Nov 2, 2023
@kalilsn kalilsn deleted the kalilsn/signup-fixes branch November 2, 2023 22:13
@kalilsn kalilsn changed the title Avoid accidentally running seed script Fix signup issues Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants