Invite Form#162
Merged
Merged
Conversation
3mcd
commented
Nov 9, 2023
Collaborator
Author
There was a problem hiding this comment.
The invite/accepted/declined pages are mostly just stubs for now. Will fill them out in a follow-up PR.
026217b to
120fcff
Compare
3mcd
commented
Nov 9, 2023
Collaborator
Author
There was a problem hiding this comment.
This discriminated union powers the type guards used throughout this integration, defined below. For example, TypeScript will complain if you try to access the userId property of an evaluator with the "unsaved" status, or if you try to access the invitedAt property of an evaluator with the "saved" status.
bdbc6f0 to
3b70a57
Compare
* Start a few invite improvements * wip * Clean up evaluator representation * WIP * Manage flow * Add a few WIP email fns * Evaluation email notifications * Tweaks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements only the invite form requirements found at https://notes.knowledgefutures.org/dash/pub/39ugws5u/overview?collectionSlug=unjournal
Issue(s) Resolved
Related to, but does not completely implement, #144 and #145
Test Plan
Too many states to outline in a test plan comprehensively. Refer to the spec above. But:
Screenshots (if applicable)
All of the various states evaluators can be in, with a single evaluator selected showing the "Send" button enabled: