Skip to content

Invite Form#162

Merged
3mcd merged 11 commits into
mainfrom
em/invite-improvements
Nov 15, 2023
Merged

Invite Form#162
3mcd merged 11 commits into
mainfrom
em/invite-improvements

Conversation

@3mcd
Copy link
Copy Markdown
Collaborator

@3mcd 3mcd commented Nov 7, 2023

This PR implements only the invite form requirements found at https://notes.knowledgefutures.org/dash/pub/39ugws5u/overview?collectionSlug=unjournal

Issue(s) Resolved

Related to, but does not completely implement, #144 and #145

Test Plan

Too many states to outline in a test plan comprehensively. Refer to the spec above. But:

  1. Submit a Pub through the submissions integration.
  2. Move the Pub to the"Under Evaluation" stage.
  3. Click "Manage Evaluations" on the Pub row/card.
  4. Add a few email addresses, saving the form (or not) as you go along.
  5. Add some duplicate evaluators after saving the form and try using the magic wand or saving again, you should get a warning message.
  6. Select one or more evaluators using the checkbox. The "Send" button should then become enabled. Click the send button. The evaluator statuses should update to "Invited".
  7. Click the Pub title in the email and either accept or reject at your discretion.
  8. The statuses should update again in the invite form.
  9. Clicking accept should take you to the evaluation form. Fill out the form and submit.
  10. The status should update to "Received" in the invite form.

Screenshots (if applicable)

All of the various states evaluators can be in, with a single evaluator selected showing the "Send" button enabled:

Screenshot 2023-11-09 at 2 34 43 PM

@isTravis isTravis requested a deployment to em/invite-improvements - core PR #162 November 7, 2023 22:24 — with Render Abandoned
@isTravis isTravis deployed to em/invite-improvements - flock PR #162 November 7, 2023 22:24 — with Render Active
@isTravis isTravis deployed to em/invite-improvements - flock PR #162 November 8, 2023 17:54 — with Render Active
@isTravis isTravis deployed to em/invite-improvements - flock PR #162 November 8, 2023 21:35 — with Render Active
@isTravis isTravis deployed to em/invite-improvements - flock PR #162 November 9, 2023 15:10 — with Render Active
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The invite/accepted/declined pages are mostly just stubs for now. Will fill them out in a follow-up PR.

Comment thread integrations/evaluations/lib/types.ts Outdated
Copy link
Copy Markdown
Collaborator Author

@3mcd 3mcd Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This discriminated union powers the type guards used throughout this integration, defined below. For example, TypeScript will complain if you try to access the userId property of an evaluator with the "unsaved" status, or if you try to access the invitedAt property of an evaluator with the "saved" status.

* Start a few invite improvements

* wip

* Clean up evaluator representation

* WIP

* Manage flow

* Add a few WIP email fns

* Evaluation email notifications

* Tweaks
@isTravis isTravis temporarily deployed to em/invite-improvements - flock PR #162 November 15, 2023 15:58 — with Render Destroyed
@isTravis isTravis temporarily deployed to em/invite-improvements - core PR #162 November 15, 2023 15:58 — with Render Destroyed
@isTravis isTravis temporarily deployed to em/invite-improvements - integration-evaluations PR #162 November 15, 2023 15:58 — with Render Destroyed
@isTravis isTravis temporarily deployed to em/invite-improvements - integration-submissions PR #162 November 15, 2023 15:58 — with Render Destroyed
@3mcd 3mcd merged commit 2524dfa into main Nov 15, 2023
@3mcd 3mcd deleted the em/invite-improvements branch November 15, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants